Skip to content

CG-10450 Integration tests improvements #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jan 28, 2025

Conversation

tkfoss
Copy link
Contributor

@tkfoss tkfoss commented Jan 28, 2025

Motivation

We want to allow running integration tests for unauthenticated contributors.

Content

  • removed installing ghcli from the code
  • make sure REPO_ID_TO_URL is populated properly
  • don't prompt user for auth if not using lfs

Testing

Manual testing.

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed
  • I have read and agree to the Contributor License Agreement

tkucar and others added 30 commits January 24, 2025 01:26
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)
… CG-10498) (#98)

# Motivation
Methods were missing return types, visibility of types in docs in light
mode was unsatisfactory

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [x] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
- [x] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: Jay Hack <[email protected]>
Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [x] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
- [x] I have read and agree to the [Contributor License
Agreement](../CLA.md)

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->
- adds exports to codebase.exports and directory.exports + directory.get_export(name) for typescript codebases
- Made a new PR so that I didn't have to deal with merge conflicts from
graphsitter renaming to codegen-sdk
- Fixed all comments from previous PR
- Added better typehints to ensure that exports are meant only for
typescript codebases and typescript specific directories

---------

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: Codegen Team (Internal) <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: Codegen Team (Internal) <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: bagel897 <[email protected]>
Co-authored-by: codegen-bot <[email protected]>
Co-authored-by: Carol Jung <[email protected]>
Co-authored-by: Rushil Patel <[email protected]>
Co-authored-by: Christine Wang <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jay Hack <[email protected]>
Co-authored-by: tomcodgen <[email protected]>
Co-authored-by: jemeza-codegen <[email protected]>
)

# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

Co-authored-by: codegen-bot <[email protected]>
Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: bagel897 <[email protected]>
Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

Co-authored-by: codegen-bot <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [x] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
- [x] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: KopekC <[email protected]>
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: codegen-bot <[email protected]>
renovate bot and others added 2 commits January 28, 2025 03:56
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@types/node](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node)
([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node))
| [`22.10.10` ->
`22.12.0`](https://renovatebot.com/diffs/npm/@types%2fnode/22.10.10/22.12.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/22.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/22.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/22.10.10/22.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/22.10.10/22.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/codegen-sh/codegen-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM5LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@tkfoss tkfoss requested a review from codegen-team as a code owner January 28, 2025 03:01
Copy link

linear bot commented Jan 28, 2025

CG-10450 Integration tests improvements

Enable unauthenticated codemod test runs

This requires auth to github.codegen.app:

uv run pytest tests/codemod/test_codemods.py -n auto

context: https://thecodegen.slack.com/archives/C070DA3BNH3/p1737663274013509?thread_ts=1737660890.493439&cid=C070DA3BNH3

Sanity check

Also: it looks like this codemod uses an outdated API? Assignment.right does not exist. Why is this test not failing

https://github.com/codegen-sh/codegen-sdk/blob/e79170cef354d21245bf028c16acc4a7df2[…]onvert_attribute_to_decorator/convert_attribute_to_decorator.py

@tkfoss tkfoss merged commit 10f68cc into develop Jan 28, 2025
8 of 13 checks passed
@tkfoss tkfoss deleted the tom-cg-10450-enable-unauthenticated-codemod-test-runs branch January 28, 2025 20:44
jayhack added a commit that referenced this pull request Feb 9, 2025
# Motivation
We want to allow running integration tests for unauthenticated
contributors.

# Content
- removed installing ghcli from the code
- make sure REPO_ID_TO_URL is populated properly
- don't prompt user for auth if not using lfs

# Testing
Manual testing.

# Please check the following before marking your PR as ready for review

- [x] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
- [x] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: Rushil Patel <[email protected]>
Co-authored-by: jemeza-codegen <[email protected]>
Co-authored-by: Jay Hack <[email protected]>
Co-authored-by: codegen-bot <[email protected]>
Co-authored-by: Carol Jung <[email protected]>
Co-authored-by: Edward-Codegen <[email protected]>
Co-authored-by: eacodegen <[email protected]>
Co-authored-by: Tawsif Kamal <[email protected]>
Co-authored-by: Codegen Team (Internal) <[email protected]>
Co-authored-by: bagel897 <[email protected]>
Co-authored-by: Joel Aguero <[email protected]>
Co-authored-by: Christine Wang <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edo Pujol <[email protected]>
Co-authored-by: KopekC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.