apply strict in_array with pass true to 3rd parameter

[samsonasik]

Ensure to make strict in_array.

Checklist:

• Securely signed commits

[MGatner]

Looks good! Curious about the credit card one.

[MGatner]

Is this one going to be worth the extra effort to ensure strict types?

[samsonasik]

phpstan complain about that, I can add @phpstan-ignore-line ignore it if you want.

[samsonasik]

It seems casting to int is required:

$info = [
    'length' => '1,2,3',  
];

$lengths = explode(',', $info['length']);
var_dump(in_array(1, $lengths, true));
var_dump(in_array('1', $lengths, true));

$lengths = array_map(function ($value) {
    return (int) $value;
}, explode(',', $info['length']));
var_dump(in_array(1, $lengths, true));

Got the following output:

bool(false)
bool(true)
bool(true)

see https://3v4l.org/lPubnY

[samsonasik]

another solution is cast the strlen() itself to string.

if (! in_array((string) strlen($ccNumber), $lengths, true))

[samsonasik]

Updated to cast the strlen() value itself to string. It should be ok now.

[MGatner]

I meant if the strict version of in_array was worth the trouble of a custom array mapping, for performance and code clarity.

Edit: Just saw your updated version, original question is moot!

[paulbalandan]

Why not just write these as 90.0, 180.0, 270.0?

[samsonasik]

because we can pass "90" as float ref https://3v4l.org/BFb9u

[MGatner]

I don't understand the difference. Isn't (float) 90 === 90.0?

[samsonasik]

oh, you're correct. I will update to 90.0, not in front of pc right now

[samsonasik]

fixed.

[samsonasik]

All green 🎉