apply strict in_array with pass true to 3rd parameter

system/API/ResponseTrait.php

@@ -390,7 +390,7 @@ protected function format($data = null)
 		$format = "application/$this->format";
 
 		// Determine correct response type through content negotiation if not explicitly declared
-		if (empty($this->format) || ! in_array($this->format, ['json', 'xml']))
+		if (empty($this->format) || ! in_array($this->format, ['json', 'xml'], true))
 		{
 			$format = $this->request->negotiate('media', $config->supportedResponseFormats, false);
 		}

system/Commands/Database/MigrateStatus.php

@@ -136,7 +136,7 @@ public function run(array $params)
 		// Loop for all $namespaces
 		foreach ($namespaces as $namespace => $path)
 		{
-			if (in_array($namespace, $this->ignoredNamespaces))
+			if (in_array($namespace, $this->ignoredNamespaces, true))
 			{
 				continue;
 			}

system/Common.php

@@ -467,7 +467,7 @@ function esc($data, string $context = 'html', string $encoding = null)
 				return $data;
 			}
 
-			if (! in_array($context, ['html', 'js', 'css', 'url', 'attr']))
+			if (! in_array($context, ['html', 'js', 'css', 'url', 'attr'], true))
 			{
 				throw new InvalidArgumentException('Invalid escape context provided.');
 			}

system/Config/BaseService.php

@@ -267,7 +267,7 @@ protected static function discoverServices(string $name, array $arguments)
 				{
 					$classname = $locator->getClassname($file);
 
-					if (! in_array($classname, ['CodeIgniter\\Config\\Services']))
+					if (! in_array($classname, ['CodeIgniter\\Config\\Services'], true))
 					{
 						static::$services[] = new $classname();
 					}

system/Database/BaseBuilder.php

@@ -513,7 +513,7 @@ protected function maxMinAvgSum(string $select = '', string $alias = '', string
 
 		$type = strtoupper($type);
 
-		if (! in_array($type, ['MAX', 'MIN', 'AVG', 'SUM', 'COUNT']))
+		if (! in_array($type, ['MAX', 'MIN', 'AVG', 'SUM', 'COUNT'], true))
 		{
 			throw new DatabaseException('Invalid function type: ' . $type);
 		}

system/Database/BaseConnection.php

@@ -602,7 +602,7 @@ public function setAliasedTables(array $aliases)
 	 */
 	public function addTableAlias(string $table)
 	{
-		if (! in_array($table, $this->aliasedTables))
+		if (! in_array($table, $this->aliasedTables, true))
 		{
 			$this->aliasedTables[] = $table;
 		}
@@ -1171,13 +1171,13 @@ public function protectIdentifiers($item, bool $prefixSingle = false, bool $prot
 			//
 			// NOTE: The ! empty() condition prevents this method
 			//       from breaking when QB isn't enabled.
-			if (! empty($this->aliasedTables) && in_array($parts[0], $this->aliasedTables))
+			if (! empty($this->aliasedTables) && in_array($parts[0], $this->aliasedTables, true))
 			{
 				if ($protectIdentifiers === true)
 				{
 					foreach ($parts as $key => $val)
 					{
-						if (! in_array($val, $this->reservedIdentifiers))
+						if (! in_array($val, $this->reservedIdentifiers, true))
 						{
 							$parts[$key] = $this->escapeIdentifiers($val);
 						}
@@ -1262,7 +1262,7 @@ public function protectIdentifiers($item, bool $prefixSingle = false, bool $prot
 			}
 		}
 
-		if ($protectIdentifiers === true && ! in_array($item, $this->reservedIdentifiers))
+		if ($protectIdentifiers === true && ! in_array($item, $this->reservedIdentifiers, true))
 		{
 			$item = $this->escapeIdentifiers($item);
 		}
@@ -1283,7 +1283,7 @@ public function protectIdentifiers($item, bool $prefixSingle = false, bool $prot
 	 */
 	public function escapeIdentifiers($item)
 	{
-		if ($this->escapeChar === '' || empty($item) || in_array($item, $this->reservedIdentifiers))
+		if ($this->escapeChar === '' || empty($item) || in_array($item, $this->reservedIdentifiers, true))
 		{
 			return $item;
 		}
@@ -1587,7 +1587,7 @@ public function listTables(bool $constrainByPrefix = false)
 	 */
 	public function tableExists(string $tableName): bool
 	{
-		return in_array($this->protectIdentifiers($tableName, true, false, false), $this->listTables());
+		return in_array($this->protectIdentifiers($tableName, true, false, false), $this->listTables(), true);
 	}
 
 	//--------------------------------------------------------------------
@@ -1662,7 +1662,7 @@ public function getFieldNames(string $table)
 	 */
 	public function fieldExists(string $fieldName, string $tableName): bool
 	{
-		return in_array($fieldName, $this->getFieldNames($tableName));
+		return in_array($fieldName, $this->getFieldNames($tableName), true);
 	}
 
 	//--------------------------------------------------------------------

system/Database/BaseUtils.php

@@ -139,7 +139,7 @@ public function listDatabases()
 	 */
 	public function databaseExists(string $database_name): bool
 	{
-		return in_array($database_name, $this->listDatabases());
+		return in_array($database_name, $this->listDatabases(), true);
 	}
 
 	//--------------------------------------------------------------------

system/Database/Forge.php

@@ -1256,7 +1256,7 @@ protected function _processIndexes(string $table)
 				continue;
 			}
 
-			if (in_array($i, $this->uniqueKeys))
+			if (in_array($i, $this->uniqueKeys, true))
 			{
 				$sqls[] = 'ALTER TABLE ' . $this->db->escapeIdentifiers($table)
 						  . ' ADD CONSTRAINT ' . $this->db->escapeIdentifiers($table . '_' . implode('_', $this->keys[$i]))
@@ -1302,12 +1302,12 @@ protected function _processForeignKeys(string $table): string
 				$sql .= ",\n\tCONSTRAINT " . $this->db->escapeIdentifiers($name_index)
 					. ' FOREIGN KEY(' . $this->db->escapeIdentifiers($field) . ') REFERENCES ' . $this->db->escapeIdentifiers($this->db->DBPrefix . $fkey['table']) . ' (' . $this->db->escapeIdentifiers($fkey['field']) . ')';
 
-				if ($fkey['onDelete'] !== false && in_array($fkey['onDelete'], $allowActions))
+				if ($fkey['onDelete'] !== false && in_array($fkey['onDelete'], $allowActions, true))
 				{
 					$sql .= ' ON DELETE ' . $fkey['onDelete'];
 				}
 
-				if ($fkey['onUpdate'] !== false && in_array($fkey['onUpdate'], $allowActions))
+				if ($fkey['onUpdate'] !== false && in_array($fkey['onUpdate'], $allowActions, true))
 				{
 					$sql .= ' ON UPDATE ' . $fkey['onUpdate'];
 				}

system/Database/MigrationRunner.php

@@ -293,7 +293,7 @@ public function regress(int $targetBatch = 0, string $group = null)
 		}
 
 		// Make sure $targetBatch is found
-		if ($targetBatch !== 0 && ! in_array($targetBatch, $batches))
+		if ($targetBatch !== 0 && ! in_array($targetBatch, $batches, true))
 		{
 			$message = lang('Migrations.batchNotFound') . $targetBatch;
 

system/Database/MySQLi/Forge.php

@@ -136,7 +136,7 @@ protected function _createTableAttributes(array $attributes): string
 			{
 				$sql .= ' ' . strtoupper($key) . ' = ';
 
-				if (in_array(strtoupper($key), $this->_quoted_table_options))
+				if (in_array(strtoupper($key), $this->_quoted_table_options, true))
 				{
 					$sql .= $this->db->escape($attributes[$key]);
 				}
@@ -265,7 +265,7 @@ protected function _processIndexes(string $table): string
 			// @phpstan-ignore-next-line
 			is_array($this->keys[$i]) || $this->keys[$i] = [$this->keys[$i]];
 
-			$unique = in_array($i, $this->uniqueKeys) ? 'UNIQUE ' : '';
+			$unique = in_array($i, $this->uniqueKeys, true) ? 'UNIQUE ' : '';
 
 			$sql .= ",\n\t{$unique}KEY " . $this->db->escapeIdentifiers(implode('_', $this->keys[$i]))
 				. ' (' . implode(', ', $this->db->escapeIdentifiers($this->keys[$i])) . ')';

system/Database/SQLite3/Forge.php

@@ -234,7 +234,7 @@ protected function _processIndexes(string $table): array
 				continue;
 			}
 
-			if (in_array($i, $this->uniqueKeys))
+			if (in_array($i, $this->uniqueKeys, true))
 			{
 				$sqls[] = 'CREATE UNIQUE INDEX ' . $this->db->escapeIdentifiers($table . '_' . implode('_', $this->keys[$i]))
 						  . ' ON ' . $this->db->escapeIdentifiers($table)

system/Debug/Exceptions.php

@@ -150,7 +150,7 @@ public function exceptionHandler(Throwable $exception)
 		] = $this->determineCodes($exception);
 
 		// Log it
-		if ($this->config->log === true && ! in_array($statusCode, $this->config->ignoreCodes))
+		if ($this->config->log === true && ! in_array($statusCode, $this->config->ignoreCodes, true))
 		{
 			log_message('critical', $exception->getMessage() . "\n{trace}", [
 							'trace' => $exception->getTraceAsString(),
@@ -219,7 +219,7 @@ public function shutdownHandler()
 		if (! is_null($error))
 		{
 			// Fatal Error?
-			if (in_array($error['type'], [E_ERROR, E_CORE_ERROR, E_COMPILE_ERROR, E_PARSE]))
+			if (in_array($error['type'], [E_ERROR, E_CORE_ERROR, E_COMPILE_ERROR, E_PARSE], true))
 			{
 				$this->exceptionHandler(new ErrorException($error['message'], $error['type'], 0, $error['file'], $error['line']));
 			}

system/Email/Email.php

@@ -813,7 +813,7 @@ public function setPriority($n = 3)
 	 */
 	public function setNewline($newline = "\n")
 	{
-		$this->newline = in_array($newline, ["\n", "\r\n", "\r"]) ? $newline : "\n";
+		$this->newline = in_array($newline, ["\n", "\r\n", "\r"], true) ? $newline : "\n";
 		return $this;
 	}
 	//--------------------------------------------------------------------
@@ -860,7 +860,7 @@ protected function getProtocol()
 	 */
 	protected function getEncoding()
 	{
-		in_array($this->encoding, $this->bitDepths) || $this->encoding = '8bit'; // @phpstan-ignore-line
+		in_array($this->encoding, $this->bitDepths, true) || $this->encoding = '8bit'; // @phpstan-ignore-line
 		foreach ($this->baseCharsets as $charset)
 		{
 			if (strpos($this->charset, $charset) === 0)

system/Encryption/Encryption.php

@@ -140,7 +140,7 @@ public function initialize(EncryptionConfig $config = null)
 		}
 
 		// Check for an unknown driver
-		if (! in_array($this->driver, $this->drivers))
+		if (! in_array($this->driver, $this->drivers, true))
 		{
 			throw EncryptionException::forUnKnownHandler($this->driver);
 		}

system/Entity.php

@@ -331,7 +331,7 @@ public function __get(string $key)
 		}
 
 		// Do we need to mutate this into a date?
-		if (in_array($key, $this->dates))
+		if (in_array($key, $this->dates, true))
 		{
 			$result = $this->mutateDate($result);
 		}
@@ -366,7 +366,7 @@ public function __set(string $key, $value = null)
 		$key = $this->mapProperty($key);
 
 		// Check if the field should be mutated into a date
-		if (in_array($key, $this->dates))
+		if (in_array($key, $this->dates, true))
 		{
 			$value = $this->mutateDate($value);
 		}
@@ -623,7 +623,7 @@ private function castAsJson($value, bool $asArray = false)
 		$tmp = ! is_null($value) ? ($asArray ? [] : new \stdClass) : null;
 		if (function_exists('json_decode'))
 		{
-			if ((is_string($value) && strlen($value) > 1 && in_array($value[0], ['[', '{', '"'])) || is_numeric($value))
+			if ((is_string($value) && strlen($value) > 1 && in_array($value[0], ['[', '{', '"'], true)) || is_numeric($value))
 			{
 				$tmp = json_decode($value, $asArray);
 

system/Format/JSONFormatter.php

@@ -66,7 +66,7 @@ public function format($data)
 
 		$result = json_encode($data, $options, 512);
 
-		if (! in_array(json_last_error(), [JSON_ERROR_NONE, JSON_ERROR_RECURSION]))
+		if (! in_array(json_last_error(), [JSON_ERROR_NONE, JSON_ERROR_RECURSION], true))
 		{
 			throw FormatException::forInvalidJSON(json_last_error_msg());
 		}

system/HTTP/ContentSecurityPolicy.php

@@ -819,7 +819,7 @@ protected function addToHeader(string $name, $values = null)
 
 			if ($reportOnly === true)
 			{
-				$reportSources[] = in_array($value, $this->validSources) ? "'{$value}'" : $value;
+				$reportSources[] = in_array($value, $this->validSources, true) ? "'{$value}'" : $value;
 			}
 			else
 			{
@@ -829,7 +829,7 @@ protected function addToHeader(string $name, $values = null)
 				}
 				else
 				{
-					$sources[] = in_array($value, $this->validSources) ? "'{$value}'" : $value;
+					$sources[] = in_array($value, $this->validSources, true) ? "'{$value}'" : $value;
 				}
 			}
 		}

system/HTTP/IncomingRequest.php

@@ -246,7 +246,7 @@ public function setLocale(string $locale)
 	{
 		// If it's not a valid locale, set it
 		// to the default locale for the site.
-		if (! in_array($locale, $this->validLocales))
+		if (! in_array($locale, $this->validLocales, true))
 		{
 			$locale = $this->defaultLocale;
 		}

system/HTTP/Message.php

@@ -78,7 +78,7 @@ class Message
 	protected $validProtocolVersions = [
 		'1.0',
 		'1.1',
-		'2',
+		'2.0',
 	];
 
 	/**
@@ -379,7 +379,7 @@ public function setProtocolVersion(string $version)
 			$version = substr($version, strpos($version, '/') + 1);
 		}
 
-		if (! in_array($version, $this->validProtocolVersions))
+		if (! in_array($version, $this->validProtocolVersions, true))
 		{
 			throw HTTPException::forInvalidHTTPProtocol(implode(', ', $this->validProtocolVersions));
 		}

system/HTTP/URI.php

@@ -896,7 +896,7 @@ public function stripQuery(...$params)
 	 * Filters the query variables so that only the keys passed in
 	 * are kept. The rest are removed from the object.
 	 *
-	 * @param array ...$params
+	 * @param string ...$params
 	 *
 	 * @return $this
 	 */
@@ -906,7 +906,7 @@ public function keepQuery(...$params)
 
 		foreach ($this->query as $key => $value)
 		{
-			if (! in_array($key, $params))
+			if (! in_array($key, $params, true))
 			{
 				continue;
 			}

system/Helpers/form_helper.php

@@ -102,7 +102,7 @@ function form_open(string $action = '', $attributes = [], array $hidden = []): s
 		$before = Services::filters()
 						  ->getFilters()['before'];
 
-		if ((in_array('csrf', $before) || array_key_exists('csrf', $before)) && strpos($action, base_url()) !== false && ! stripos($form, 'method="get"'))
+		if ((in_array('csrf', $before, true) || array_key_exists('csrf', $before)) && strpos($action, base_url()) !== false && ! stripos($form, 'method="get"'))
 		{
 			$form .= csrf_field($csrfId ?? null);
 		}
@@ -423,7 +423,7 @@ function form_dropdown($data = '', $options = [], $selected = [], $extra = ''):
 				$form .= '<optgroup label="' . $key . "\">\n";
 				foreach ($val as $optgroup_key => $optgroup_val)
 				{
-					$sel   = in_array($optgroup_key, $selected) ? ' selected="selected"' : '';
+					$sel   = in_array($optgroup_key, $selected, true) ? ' selected="selected"' : '';
 					$form .= '<option value="' . htmlspecialchars($optgroup_key) . '"' . $sel . '>'
 							. $optgroup_val . "</option>\n";
 				}
@@ -432,7 +432,7 @@ function form_dropdown($data = '', $options = [], $selected = [], $extra = ''):
 			else
 			{
 				$form .= '<option value="' . htmlspecialchars($key) . '"'
-						. (in_array($key, $selected) ? ' selected="selected"' : '') . '>'
+						. (in_array($key, $selected, true) ? ' selected="selected"' : '') . '>'
 						. $val . "</option>\n";
 			}
 		}

system/Helpers/html_helper.php

@@ -323,7 +323,7 @@ function link_tag($href = '', string $rel = 'stylesheet', string $type = 'text/c
 
 		$link .= 'rel="' . $rel . '" ';
 
-		if (! in_array($rel, ['alternate', 'canonical']))
+		if (! in_array($rel, ['alternate', 'canonical'], true))
 		{
 			$link .= 'type="' . $type . '" ';
 		}

system/Helpers/inflector_helper.php

@@ -339,7 +339,7 @@ function is_pluralizable(string $word): bool
 						   'weather',
 						   'wisdom',
 						   'work',
-					   ]);
+					   ], true);
 
 		return ! $uncountables;
 	}

system/Images/Handlers/BaseHandler.php

@@ -361,12 +361,12 @@ public function rotate(float $angle)
 	{
 		// Allowed rotation values
 		$degs = [
-			90,
-			180,
-			270,
+			90.0,
+			180.0,
+			270.0,
 		];
 
-		if (! in_array($angle, $degs))
+		if (! in_array($angle, $degs, true))
 		{
 			throw ImageException::forMissingAngle();
 		}

system/Images/Handlers/ImageMagickHandler.php

@@ -388,7 +388,7 @@ protected function supportedFormatCheck()
 		switch ($this->image()->imageType)
 		{
 			case IMAGETYPE_WEBP:
-				if (! in_array('WEBP', \Imagick::queryFormats()))
+				if (! in_array('WEBP', \Imagick::queryFormats(), true))
 				{
 					throw ImageException::forInvalidImageCreate(lang('images.webpNotSupported'));
 				}

system/Language/Language.php

@@ -295,7 +295,7 @@ protected function load(string $file, string $locale, bool $return = false)
 			$this->loadedFiles[$locale] = [];
 		}
 
-		if (in_array($file, $this->loadedFiles[$locale]))
+		if (in_array($file, $this->loadedFiles[$locale], true))
 		{
 			// Don't load it more than once.
 			return [];