Skip to content

Refactor FiltersTest.php #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 1, 2021
Merged

Refactor FiltersTest.php #5242

merged 10 commits into from
Nov 1, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 26, 2021

Description

  • refactor

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Oct 26, 2021
View reviewed changes
@kenjis
Copy link
Member Author

kenjis commented Oct 28, 2021

I would like to move createConfigFromArray() to reuse.
https://github.com/codeigniter4/CodeIgniter4/pull/5242/files#diff-ae159768f526f66aeb6af1c17c64b57f36659a0d795530b3014a5ded5cbd6176R72

Where should it go?

paulbalandan
paulbalandan reviewed Oct 28, 2021
View reviewed changes
MGatner
MGatner reviewed Oct 31, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensive changes! Tests are passing so I'm good with it, looks like a lot of improvements. Please address Paul's review.

@kenjis kenjis force-pushed the refactor-FiltersTest branch from c8c28f7 to f72c694 Compare November 1, 2021 00:29
@kenjis kenjis force-pushed the refactor-FiltersTest branch from f72c694 to 3b2fd6e Compare November 1, 2021 00:40
@kenjis kenjis merged commit 9810218 into codeigniter4:develop Nov 1, 2021
@kenjis kenjis deleted the refactor-FiltersTest branch November 1, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @samsonasik @MGatner @paulbalandan