Skip to content

Refactor FiltersTest.php #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 1, 2021
Merged

Refactor FiltersTest.php #5242

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d8b750b
test: refactor: $request -> $this->request
kenjis Oct 26, 2021
1f4ba30
test: refactor: reset $_SERVER
kenjis Oct 26, 2021
3ea1ede
test: refactor: change the position of line breaks
kenjis Oct 26, 2021
64b3778
test: refactor: extract createFilters() method
kenjis Oct 26, 2021
df72c88
test: refactor: use ::class keyword
kenjis Oct 26, 2021
908c562
test: refactor: remove unused property
kenjis Oct 26, 2021
01fc237
test: refactor: fix wrong config class type
kenjis Oct 28, 2021
1d9c1b6
test: refactor: remove $this->request that I forgot to remove
kenjis Oct 28, 2021
24713d4
test: refactor: use method chaining
kenjis Oct 28, 2021
3b2fd6e
refactor: remove else
kenjis Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading