Skip to content

chore: update .github/workflows/deploy-framework.yml #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 10, 2021

Description

  • replace github.repos. with github.rest.repos.

See #5294 (comment)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis mentioned this pull request Nov 10, 2021
@kenjis kenjis requested a review from MGatner November 10, 2021 01:38
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the original by changing the repo names to my own account space and making releases there. Since this is only the final release step though I think we just try it on next release, because it only takes about 30 seconds to fix if t workflow fails.

@kenjis kenjis merged commit 0d704d8 into codeigniter4:develop Nov 10, 2021
@kenjis kenjis deleted the fix-deploy-framework.yml branch November 10, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants