Skip to content

4.1.5 Ready code #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 588 commits into from
Nov 8, 2021
Merged

4.1.5 Ready code #5294

merged 588 commits into from
Nov 8, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Nov 8, 2021

No description provided.

kenjis and others added 30 commits October 12, 2021 12:49
There are a lot of contents.
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.11.57...0.11.58)

---
updated-dependencies:
- dependency-name: rector/rector
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[Debug] Add formatted query string to timeline.
* Sort highlighted keywords alphabetically.

* Add new composite keywords.

* Deconstruct composite keywords.

* Add basic test for query highlighting in toolbar.

* Ignore keywords in string values of queries.

* Use generic table and column names for tests.

* Add credits for regex pattern.

* Escape HTML entities when formatting query string.

* Use esc() for escaping query string.
* refactor: case the existence of config files with if statements

To make it easier to know which parts to delete in the future.

* docs: fix PHPDoc explanation

* fix: bug that CSRF cookie is not sent just by calling csrf_hash()

When the CSRF filter was set to POST method, it did not work.

* refactor: replace deprecated method getHeader()

* refactor: extract method

* refactor: extract method

* refactor: extract method

* refactor: use $this->hash instead of $_COOKIE

* test: fix the timing for setting superglobals

* test: fix Cannot modify header information

ErrorException: Cannot modify header information - headers already sent by ...

* style: vendor/bin/rector process

* refactor: ensure instance

It becomes clear that it is `SecurityConfig`.

Co-authored-by: Abdul Malik Ikhsan <[email protected]>

* refactor: ensure instance

It becomes clear that it is `CookieConfig`.

Co-authored-by: Abdul Malik Ikhsan <[email protected]>

* refactor: when $cookie is null, Cookie::setDefaults($cookie) does nothing

* refactor: extract method

* fix: make private extracted methods

* fix: make private added property

* fix: fallback to the local properties

Takes care when a user removes properties in config classes.

* refactor: use $request instead of $_POST

Co-authored-by: Abdul Malik Ikhsan <[email protected]>
* fix #4169 GC processing issues when session lifetime is 0

* Added description about the structure of the session library of the document.

* Apply suggestions from code review

Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
`var` is a symlink to `private/var` on macOS
* test: add `@group CacheLive`

* docs: add about CacheLive
docs: unify the decoration of app/Config/*.php
It must be in the class PHPdoc.
kenjis and others added 23 commits November 5, 2021 16:28
Removed in latest rector dev-main
[Rector] Remove FixClassCaseSensitivityNameRector
fix: module filters are not discovered when using route filters
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
docs: fix RST format in caching.rst
Reduce memory usage of insertBatch(), updateBatch()
@MGatner MGatner merged commit 8c7f701 into master Nov 8, 2021
@totoprayogo1916
Copy link
Contributor

Repo Framework & Appstarter still in v4.1.4

@MGatner @paulbalandan

@kenjis
Copy link
Member

kenjis commented Nov 9, 2021

@MGatner
Copy link
Member Author

MGatner commented Nov 9, 2021

Looks like this was broken with the update to version 5 of github-script: 72cd330#diff-02131a2dbc3b22f90f5a8c85b30d8ee770211489caed215e4e1284e318268f67

There were some breaking changes (https://github.com/actions/github-script#breaking-changes-in-v5) but it is not immediately apparent what needs to happen. I will do a manual release (in 1-2 hours) and then look into this when I get a chance.

@MGatner
Copy link
Member Author

MGatner commented Nov 9, 2021

The scripts all ran, it was just the final workflow step of creating the release that fails. I've created the releases manually now - we will new to fix the action before next release.

@kenjis
Copy link
Member

kenjis commented Nov 10, 2021

@MGatner I sent a PR: #5301
But I don't know how to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants