fix: make Time::__toString() database-compatible on any locale #6461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kenjis
added
bug
|
I think this is the way to go. Since that format is very clearly "database DateTime" I expect the intent was always to have the Stringable be database-compatible. |
MGatner
approved these changes
Sep 6, 2022
kenjis
changed the title
It always returns string like '2016-03-09 12:00:00'.
kenjis
force-pushed
the
fix-Time-toString
branch
from
0bb6483 to
3e2e401
Compare
setUp()/tearDown() take care of it.
datamweb
suggested changes
Sep 7, 2022
kenjis
force-pushed
the
fix-Time-toString
branch
from
dbf7348 to
32e6c9d
Compare
Co-authored-by: Pooya Parsa Dadashi <[email protected]>
|
Added the docs. |
paulbalandan
reviewed
Sep 7, 2022
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
paulbalandan
approved these changes
Sep 7, 2022
MGatner
approved these changes
Sep 7, 2022
datamweb
approved these changes
Sep 7, 2022
|
Thank you all! |
|
🎉 |
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Sep 8, 2022
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6439
Supersedes #6456
In this PR,
Time::__toString()no longer depends on locale.It always returns database-compatible string like
'2016-03-09 12:00:00'.In the current implementation, the
__toString()output will be changed by the locale.(But it seems it is not documented in the User Guide.)
It causes database query error in a few locale.
Time is localized class, but
__toString()does not need to return localized value.If a dev needs localized string, they can call toDateTimeString().
Implicitly changing behavior depending on locale is a bad practice because it confuses developers.
__toString()is a standard PHP method, not a localized helper method.The return value should be database-compatible.
Checklist: