Skip to content

test: update TimeTest::testToDatabase() #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2022

Description
See #6461

There was 1 failure:

1) CodeIgniter\I18n\TimeTest::testToDatabase
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'۲۰۱۷-۰۱-۱۲ ۰۰:۰۰:۰۰'
+'2017-01-12 00:00:00'

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/I18n/TimeTest.php:1169
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/runs/8238507830?check_suite_focus=true

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.3 testing Pull requests that changes tests only labels Sep 8, 2022
@kenjis
Copy link
Member Author

kenjis commented Sep 8, 2022

I would like to remove Time::toDatabase(), because it is exactly the same as __toString() now.

@datamweb
Copy link
Contributor

datamweb commented Sep 8, 2022

Removing Time::toDatabase() seems logical. MGatner was always in his favor, you should see if he agrees with us or not.

@kenjis kenjis merged commit 1e30fca into codeigniter4:4.3 Sep 8, 2022
@kenjis kenjis deleted the test-update-Time-toDatabase branch September 8, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants