Skip to content

Fix CreateDatabaseTest to not leave database #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix CreateDatabaseTest to not leave database #6867

merged 2 commits into from
Nov 17, 2022

Conversation

paulbalandan
Copy link
Member

Description
The last test would leave the foobar database not dropped.

Follow up to #6856 and #6858

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Nov 15, 2022
@samsonasik samsonasik merged commit 98178a1 into codeigniter4:develop Nov 17, 2022
@samsonasik
Copy link
Member

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the fix-create-database-test branch November 17, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @samsonasik @kenjis