Skip to content

fix: [OCI8] if conditions to build DSN #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2024
Merged

fix: [OCI8] if conditions to build DSN #8986

merged 5 commits into from
Jun 24, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 22, 2024 •
edited
Loading

Description
See #8984 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jun 22, 2024
@kenjis kenjis mentioned this pull request Jun 22, 2024
Closed
kenjis added 4 commits June 22, 2024 15:10
@kenjis
fix: if conditions to build DSN
54b0441
@kenjis
refactor: replace empty()
9a9da14
@kenjis
fix: Deprecated
fa5f5c6 
ctype_digit(): Argument of type int will be interpreted as string in the future
@kenjis
refactor: replace empty()
5ee0df2
@kenjis kenjis force-pushed the fix-OCI8-connect branch from c685781 to 5ee0df2 Compare June 22, 2024 06:11
michalsn
michalsn approved these changes Jun 22, 2024
View reviewed changes
@kenjis kenjis merged commit ab64aeb into codeigniter4:develop Jun 24, 2024
41 checks passed
@kenjis kenjis deleted the fix-OCI8-connect branch June 24, 2024 00:24
@kenjis kenjis mentioned this pull request Jun 27, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb