Skip to content

refactor: Fix phpstan isset offset #9383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neznaika0
Copy link
Contributor

Description
It seems $matches always has 6 keys. In addition, other indexes are not checked - they are expected to exist.

┌─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ $matches                                                                                                                                                                                            │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
array (6) [
    0 => string (34) " j.name  LIKE :j.name: ESCAPE '!' "
    1 => string (0) ""
    2 => string (7) " j.name"
    3 => string (27) "  LIKE :j.name: ESCAPE '!' "
    4 => string (0) ""
    5 => string (0) ""
]

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go to develop branch.

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 8, 2025
@neznaika0 neznaika0 force-pushed the refactor/phpstan-isset-offset branch from a03ddb1 to 5493fda Compare January 8, 2025 15:49
@neznaika0 neznaika0 changed the base branch from 4.6 to develop January 8, 2025 15:49
@paulbalandan paulbalandan merged commit 9de9856 into codeigniter4:develop Jan 8, 2025
49 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-isset-offset branch January 8, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants