feat: add env configuration option #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totalolage
commented
Jun 7, 2025
totalolage
commented
- Add env field to config for passing environment variables to Claude CLI
- Update init.lua to pass env variables when spawning Claude terminal
- Allows users to set custom environment like ANTHROPIC_API_KEY
- Add env field to config for passing environment variables to Claude CLI - Update init.lua to pass env variables when spawning Claude terminal - Allows users to set custom environment like ANTHROPIC_API_KEY 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ThomasK33
reviewed
Jun 7, 2025
Comment on lines
+87
to
+93
| -- Check environment variable for terminal_cmd if not set in user config | ||
| if config.terminal_cmd == nil then | ||
| local env_cmd = vim.fn.getenv("CLAUDE_TERMINAL_CMD") | ||
| if env_cmd ~= vim.NIL then | ||
| config.terminal_cmd = env_cmd | ||
| end | ||
| end |
There was a problem hiding this comment.
I would rather have the user configure that in their settings and then pass that value into the terminal_cmd instead of us doing it here.
Comment on lines
+101
to
+102
|
|
||
|
|
There was a problem hiding this comment.
these should be removed if you run nix fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.