-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add env configuration option #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
totalolage
wants to merge
1
commit into
coder:main
Choose a base branch
from
totalolage:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ M.defaults = { | |
port_range = { min = 10000, max = 65535 }, | ||
auto_start = true, | ||
terminal_cmd = nil, | ||
env = {}, -- Custom environment variables for Claude terminal | ||
log_level = "info", | ||
track_selection = true, | ||
visual_demotion_delay_ms = 50, -- Milliseconds to wait before demoting a visual selection | ||
|
@@ -61,6 +62,13 @@ function M.validate(config) | |
assert(type(config.diff_opts.vertical_split) == "boolean", "diff_opts.vertical_split must be a boolean") | ||
assert(type(config.diff_opts.open_in_current_tab) == "boolean", "diff_opts.open_in_current_tab must be a boolean") | ||
|
||
-- Validate env | ||
assert(type(config.env) == "table", "env must be a table") | ||
for key, value in pairs(config.env) do | ||
assert(type(key) == "string", "env keys must be strings") | ||
assert(type(value) == "string", "env values must be strings") | ||
end | ||
|
||
return true | ||
end | ||
|
||
|
@@ -76,9 +84,19 @@ function M.apply(user_config) | |
config = vim.tbl_deep_extend("force", config, user_config) | ||
end | ||
|
||
-- Check environment variable for terminal_cmd if not set in user config | ||
if config.terminal_cmd == nil then | ||
local env_cmd = vim.fn.getenv("CLAUDE_TERMINAL_CMD") | ||
if env_cmd ~= vim.NIL then | ||
config.terminal_cmd = env_cmd | ||
end | ||
end | ||
|
||
M.validate(config) | ||
|
||
return config | ||
end | ||
|
||
return M | ||
|
||
|
||
Comment on lines
+101
to
+102
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these should be removed if you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have the user configure that in their settings and then pass that value into the terminal_cmd instead of us doing it here.