-
-
Notifications
You must be signed in to change notification settings - Fork 288
4.8.3 candidate #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
4.8.3 candidate #1457
Conversation
Hey @woile @noirbizarre , I'd like to merge this one in the next few days. It contains all the PRs I reviewed this days to avoid bumping version too quickly |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
+ Coverage 97.33% 97.92% +0.59%
==========================================
Files 42 58 +16
Lines 2104 2704 +600
==========================================
+ Hits 2048 2648 +600
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@bearomorphism, please let us know if you want us to include anything in the next release. We'll try to review them |
and probably #1453 which I'm fixing |
and #1442 |
Those are small PRs (<60 lines of code changes excluding tests). Thanks 🙇 |
And probably #1466 |
I hope to get it done this week... will try to review some more 💪 |
@Lee-W It seems that your latest force-push broke things. Could you revert it? |
This commit is good |
I'm a damn idoit 🤦♂️ |
…o avoid confusion
@bearomorphism I think i get it restored and push to this one |
This is also easy to review, thanks |
Description
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context