ci(pyproject.toml): strict check for invalid commit messages #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1494 +/- ##
==========================================
Coverage 97.92% 97.92%
==========================================
Files 58 58
Lines 2704 2704
==========================================
Hits 2648 2648
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
ci-pr-check-fix
branch
4 times, most recently
from
1dffc7d to
74d92d2
Compare
bearomorphism
commented
Jun 2, 2025
| check-commit.help = "Check the commit message" | ||
| check-commit.cmd = "cz -nr 3 check --rev-range origin/master.." | ||
| check-commit.help = "Check the commit messages" | ||
| check-commit.cmd = "poetry run cz --no-raise 3 check --rev-range origin/master.." |
There was a problem hiding this comment.
Added poetry run so the command can run on windows platform.
|
btw it would be great if we can check in this PR after #1457 because there will probably be conflicts and I want to fix the conflicts in this branch. |
let's mark it draft then |
bearomorphism
force-pushed
the
ci-pr-check-fix
branch
from
e192688 to
c18d8aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1493
Description
check-committask beforecoverinpoetry allcommand.Checklist
Expected Behavior
Steps to Test This Pull Request
#1495 CI should not pass.
Additional Context