-
-
Notifications
You must be signed in to change notification settings - Fork 19
Fix typos and wrong pip version range #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos and wrong pip version range #147
Conversation
@@ -59,7 +59,7 @@ def __call__( | |||
|
|||
|
|||
def arg_parser() -> argparse.ArgumentParser: | |||
"""Build the arrgument parser.""" | |||
"""Build the argument parser.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏴☠️
@@ -216,7 +216,7 @@ def traverse( | |||
skip_command_line1: bool, | |||
skip_command_line2: bool, | |||
) -> Tuple[Union[cwl.CommandLineTool, cwl.ExpressionTool, cwl.Workflow], bool]: | |||
"""Convert the given process and any subprocesess.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were typos in the cwl files under the parser package, but there's a note at the top of those files saying they are auto-generated (i.e. better fix the typos at the source, if not already fixed). I noticed these other *expression_refactor files have similar typos, but not sure if these are also auto-generated? Happy to remove them from the PR if needed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expression refactor files are not autogenerated. So typo fixes are appreciated, thanks!
copyright = '2019, CWL Commmunity' | ||
author = 'CWL Commmunity' | ||
copyright = '2019, CWL Community' | ||
author = 'CWL Community' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what started this PR. Went to look at the Sphinx issue in #146 , and noticed the typo above. Then ran the Code Inspection in PyCharm to check for other typos.
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 22.42% 22.42%
=======================================
Files 27 27
Lines 20629 20629
Branches 5762 5762
=======================================
Hits 4627 4627
Misses 14998 14998
Partials 1004 1004
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
No description provided.