-
-
Notifications
You must be signed in to change notification settings - Fork 19
Fix typos and wrong pip version range #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -216,7 +216,7 @@ def traverse( | |
skip_command_line1: bool, | ||
skip_command_line2: bool, | ||
) -> Tuple[Union[cwl.CommandLineTool, cwl.ExpressionTool, cwl.Workflow], bool]: | ||
"""Convert the given process and any subprocesess.""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There were typos in the cwl files under the parser package, but there's a note at the top of those files saying they are auto-generated (i.e. better fix the typos at the source, if not already fixed). I noticed these other *expression_refactor files have similar typos, but not sure if these are also auto-generated? Happy to remove them from the PR if needed 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The expression refactor files are not autogenerated. So typo fixes are appreciated, thanks! |
||
"""Convert the given process and any subprocesses.""" | ||
if not inside and isinstance(process, cwl.CommandLineTool): | ||
process = expand_stream_shortcuts(process) | ||
wf_inputs = [] | ||
|
@@ -1488,7 +1488,7 @@ def traverse_CommandLineTool( | |
) | ||
new_clt_step = copy.copy( | ||
step | ||
) # a deepcopy would be convienant, but params2.cwl gives it problems | ||
) # a deepcopy would be convenient, but params2.cwl gives it problems | ||
new_clt_step.id = cast(str, new_clt_step.id).split("#")[-1] | ||
new_clt_step.run = copy.copy(step.run) | ||
new_clt_step.run.id = None | ||
|
@@ -1515,7 +1515,7 @@ def traverse_CommandLineTool( | |
) | ||
else: | ||
raise Exception( | ||
"Unimplemented OutputParamter type: %s", | ||
"Unimplemented OutputParameter type: %s", | ||
type(new_outp), | ||
) | ||
new_clt_step.in_ = copy.deepcopy(step.in_) | ||
|
@@ -1595,7 +1595,7 @@ def remove_JSReq( | |
process: Union[cwl.CommandLineTool, cwl.WorkflowStep, cwl.Workflow], | ||
skip_command_line1: bool, | ||
) -> None: | ||
"""Since the InlineJavascriptRequiment is longer needed, remove it.""" | ||
"""Since the InlineJavascriptRequirement is longer needed, remove it.""" | ||
if skip_command_line1 and isinstance(process, cwl.CommandLineTool): | ||
return | ||
if process.hints: | ||
|
@@ -1958,7 +1958,7 @@ def traverse_step( | |
def workflow_step_to_InputParameters( | ||
step_ins: List[cwl.WorkflowStepInput], parent: cwl.Workflow, except_in_id: str | ||
) -> List[cwl.InputParameter]: | ||
"""Create InputParametes to match the given WorkflowStep inputs.""" | ||
"""Create InputParameters to match the given WorkflowStep inputs.""" | ||
params = [] | ||
for inp in step_ins: | ||
if not inp.id: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,8 +18,8 @@ | |
# -- Project information ----------------------------------------------------- | ||
|
||
project = 'cwl-utils' | ||
copyright = '2019, CWL Commmunity' | ||
author = 'CWL Commmunity' | ||
copyright = '2019, CWL Community' | ||
author = 'CWL Community' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is what started this PR. Went to look at the Sphinx issue in #146 , and noticed the typo above. Then ran the Code Inspection in PyCharm to check for other typos. |
||
|
||
|
||
# -- General configuration --------------------------------------------------- | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
mypy==0.971 | ||
typing_extensions | ||
types-requests | ||
types-setuptools>==57.4.0 | ||
types-setuptools>=57.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏴☠️