Skip to content

Added pull_request_template.md #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

mcbarton
Copy link
Collaborator

This PR adds a basic pull request template to the repo. @vgvassilev @anutosh491 This PR is ready for review.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (6692a45) to head (09a7f08).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   70.09%   75.08%   +4.98%     
==========================================
  Files          17       17              
  Lines         602      602              
  Branches       59       59              
==========================================
+ Hits          422      452      +30     
+ Misses        180      150      -30     

see 3 files with indirect coverage changes

see 3 files with indirect coverage changes

@vgvassilev vgvassilev requested a review from JohanMabille May 22, 2024 18:52
@anutosh491
Copy link
Collaborator

Well tough to comment on what sort of PR template we need (and if we need one) cause I've not seen any other xues stack have one :|

@mcbarton
Copy link
Collaborator Author

@JohanMabille can you review this PR for me?

@mcbarton
Copy link
Collaborator Author

@vgvassilev can you see if you can get this PR looked at?

@mcbarton mcbarton mentioned this pull request May 31, 2024
Copy link
Collaborator

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, and sorry for the late review! I think we can simplify it a bit, especially the latest section (checklist) adds too much "noise" to the template and could be removed.

@mcbarton mcbarton requested a review from JohanMabille May 31, 2024 15:17
@mcbarton
Copy link
Collaborator Author

@JohanMabille I have removed the checklist section and tests section. This should address all your comments. Are you happy with it now?

@JohanMabille
Copy link
Collaborator

Yep, thanks ;)

@JohanMabille JohanMabille merged commit 502299f into compiler-research:main Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants