Skip to content

Update issue template #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

This PR updates the issue template for the repo to complement the PR which adds a pull request template here #118

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (13e56df) to head (12b63f3).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   75.08%   79.41%   +4.32%     
==========================================
  Files          17       17              
  Lines         602      612      +10     
  Branches       59       59              
==========================================
+ Hits          452      486      +34     
+ Misses        150      126      -24     

see 5 files with indirect coverage changes

see 5 files with indirect coverage changes

@mcbarton
Copy link
Collaborator Author

mcbarton commented May 31, 2024

@anutosh491 @JohanMabille @alexander-penev can one you please review this PR and the other one linked?

mcbarton added a commit to mcbarton/xeus-cpp that referenced this pull request May 31, 2024
@mcbarton mcbarton force-pushed the Update-issues-template branch from 89c3b8d to b5df3bf Compare May 31, 2024 16:50
@mcbarton mcbarton requested a review from JohanMabille May 31, 2024 20:15
@mcbarton
Copy link
Collaborator Author

@JohanMabille can you take another look at this PR? I fixed all the issues you raised except switching to Github labels. With regards to the Github labels issue I plan to add a workflow which automatically tags each new issue a 'Needs Review' label (needs creating if you could do this for me since I don't have the permissions to do this). It will then be upto the person who reviews the issue to add the correct labels based on the description of the issue.

@vgvassilev
Copy link
Contributor

Can you try again to create a label? I added you to the repo.

@mcbarton
Copy link
Collaborator Author

Can you try again to create a label? I added you to the repo.

Thank you I am now able to add a label :)

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 1, 2024

@JohanMabille I have now addressed all your issues with this PR and its ready for another review.

@JohanMabille
Copy link
Collaborator

Can I suggest to use the label "Needs triage" instead of "Needs review" for new issues? It is more widespread in OSS repos (at least on GH). otherwise, LGTM.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 4, 2024

Can I suggest to use the label "Needs triage" instead of "Needs review" for new issues? It is more widespread in OSS repos (at least on GH). otherwise, LGTM.

@JohanMabille done.

@JohanMabille JohanMabille merged commit 7e5b820 into compiler-research:main Jun 4, 2024
8 checks passed
@JohanMabille
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants