Skip to content

CI: re-enable TSC build on Windows #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Conversation

egorzhdan
Copy link
Contributor

@egorzhdan egorzhdan commented Aug 6, 2020

This PR re-enables the Swift TSC build on Windows which is fixed in swiftlang/swift-tools-support-core#98.

Since TSC depends on SQLite3 now, this PR also adds the required CMake arguments.


This change is Reviewable

Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@compnerd
Copy link
Owner

compnerd commented Aug 6, 2020

/azp run VS2019

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@compnerd
Copy link
Owner

compnerd commented Aug 6, 2020

sigh whatever, I'll deal with the fallout and just merge this without testing.

@compnerd compnerd merged commit d1d7ce6 into compnerd:master Aug 6, 2020
@compnerd
Copy link
Owner

compnerd commented Aug 6, 2020

@egorzhdan thanks for the PR!

@compnerd
Copy link
Owner

compnerd commented Aug 7, 2020

@egorzhdan - this definitely hasn't been fixed: https://dev.azure.com/compnerd/3133d6ab-80a8-4996-ac4f-03df25cd3224/_apis/build/builds/35533/logs/377

Could you please look into the build failure?

@egorzhdan
Copy link
Contributor Author

@compnerd yeap, it's one of the issues I've fixed in swiftlang/swift-tools-support-core#98, but that PR isn't merged yet.
I probably should have mentioned that in the description, sorry.

@compnerd
Copy link
Owner

compnerd commented Aug 7, 2020

Do you know when its likely to get merged? Otherwise, it might make sense to revert this change.

@egorzhdan
Copy link
Contributor Author

I don't know, since I don't have the CI/commit access I can't really speed up the process.

@egorzhdan
Copy link
Contributor Author

@compnerd swiftlang/swift-tools-support-core#98 was merged, the build should pass now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants