-
Notifications
You must be signed in to change notification settings - Fork 55
CI: re-enable TSC build on Windows #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
/azp run VS2019 |
No pipelines are associated with this pull request. |
sigh whatever, I'll deal with the fallout and just merge this without testing. |
@egorzhdan thanks for the PR! |
@egorzhdan - this definitely hasn't been fixed: https://dev.azure.com/compnerd/3133d6ab-80a8-4996-ac4f-03df25cd3224/_apis/build/builds/35533/logs/377 Could you please look into the build failure? |
@compnerd yeap, it's one of the issues I've fixed in swiftlang/swift-tools-support-core#98, but that PR isn't merged yet. |
Do you know when its likely to get merged? Otherwise, it might make sense to revert this change. |
I don't know, since I don't have the CI/commit access I can't really speed up the process. |
@compnerd swiftlang/swift-tools-support-core#98 was merged, the build should pass now |
This PR re-enables the Swift TSC build on Windows which is fixed in swiftlang/swift-tools-support-core#98.
Since TSC depends on SQLite3 now, this PR also adds the required CMake arguments.
This change is