Skip to content

Vulkan: Add device architecture enum and logic to recognize AMD generations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

0cc4m
Copy link

@0cc4m 0cc4m commented Mar 8, 2025

This is my attempt at recognizing the AMD generations in a least-hacky-as-possible way. RDNA3 currently also encompasses RDNA4, but I don't think that's a big issue. Can you test this and let me know what you think?

@daniandtheweb
Copy link
Owner

daniandtheweb commented Mar 8, 2025

Looks good to me, I tested it by editing the required subgroup code and everything seems to work fine on RDNA3.

Regarding the RDNA3 and RDNA4 ambiguity I've noticed looking at gpuinfo that RDNA4 supports some more VK_EXT_shader_atomic_float2 operations like shaderImageFloat32AtomicMinMax, maybe that can be used to differ the two architectures?

I'll test it in a bit on the 5700XT too.

@0cc4m
Copy link
Author

0cc4m commented Mar 8, 2025

I checked that it works on GCN and RDNA2, at least on Linux.

Be aware there are some differences between RADV and AMDVLK/The Windows driver, and there are barely any vulkaninfo reports for RDNA4 for now. But if you see a way to recognize it, feel free to implement it. Or leave it for the future.

@daniandtheweb
Copy link
Owner

I've compared the same driver version on the windows driver and those features seem to be one of the few not present on any other RDNA card, however I agree that more it's better to wait for more reports about the card.

On 5700xt (and I guess any other RDNA1) works fine.

If you're okay with it I can merge this on my branch.

@0cc4m
Copy link
Author

0cc4m commented Mar 8, 2025

Yeah, go ahead.

@daniandtheweb daniandtheweb reopened this Mar 8, 2025
@daniandtheweb daniandtheweb merged commit 3be7bc0 into daniandtheweb:rdna-subgroup-size Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants