Skip to content

rename isnull and isnan methods #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MarcoGorelli
Copy link
Contributor

as discussed on the last call

@rgommers
Copy link
Member

I don't remember what the rationale for this was, can you add one @MarcoGorelli? These methods are using the no-underscore flavor pretty much universally I think, and also in the array API for isnan.

@MarcoGorelli
Copy link
Contributor Author

just snake-case - you'd read it as "is null", and replacing the space with an underscore, would get "is_null"

@rgommers
Copy link
Member

Hmm - I'd think that that's probably not a good reason for is and has, they're kinda special in Python (isinstance, issubclass, hasattr, etc.) - that plus isnan/isnull being the current names everywhere means we should probably leave this as is.

@MarcoGorelli
Copy link
Contributor Author

OK sure, closing then

@jorisvandenbossche
Copy link
Member

everywhere

Just to be pedantic, but not "everywhere": for example pyarrow and polars both use "is_null" etc (but yeah, those are certainly the outliers and probably less relevant for the exercise here)

@MarcoGorelli MarcoGorelli mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants