use snake case #178
Merged
use snake case #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, especially given that we also use |
rgommers
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Thanks Marco. I'm happy either way here; it's a stylistic thing and I've been trying to retreat from having strong opinions on those in all my projects:) So I'll just add my approval review here. Will merge within the next day or two unless there's more discussion.
|
thanks for your reviews merging then to keep things moving, can revert if there's objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resurrecting #111 as this has been annoying me slightly
it's true that python numpy and pandas are inconsistent here, but we have chance to do things differently and better in this standard - I suggest we just use snake case consistently