Skip to content

use snake case #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/API_specification/dataframe_api/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"column_from_sequence",
"concat",
"dataframe_from_dict",
"isnull",
"is_null",
"null",
]

Expand Down Expand Up @@ -99,7 +99,7 @@ class null:
From ``__eq__`` and from ``__bool__``.

For ``__eq__``: a missing value must not be compared for equality
directly. Instead, use `DataFrame.isnull` or `Column.isnull` to check
directly. Instead, use `DataFrame.is_null` or `Column.is_null` to check
for presence of missing values.

For ``__bool__``: truthiness of a missing value is ambiguous.
Expand All @@ -113,7 +113,7 @@ class null:
"""
...

def isnull(value: object, /) -> bool:
def is_null(value: object, /) -> bool:
"""
Check if an object is a `null` scalar.

Expand Down
8 changes: 4 additions & 4 deletions spec/API_specification/dataframe_api/column_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def var(self, *, skip_nulls: bool = True) -> DType:
dtypes.
"""

def isnull(self) -> Column:
def is_null(self) -> Column:
"""
Check for 'missing' or 'null' entries.

Expand All @@ -390,7 +390,7 @@ def isnull(self) -> Column:

See also
--------
isnan
is_nan

Notes
-----
Expand All @@ -399,7 +399,7 @@ def isnull(self) -> Column:
but note that the Standard makes no guarantees about them.
"""

def isnan(self) -> Column:
def is_nan(self) -> Column:
"""
Check for nan entries.

Expand All @@ -409,7 +409,7 @@ def isnan(self) -> Column:

See also
--------
isnull
is_null

Notes
-----
Expand Down
8 changes: 4 additions & 4 deletions spec/API_specification/dataframe_api/dataframe_object.py
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ def var(self, *, skip_nulls: bool = True) -> DataFrame:
"""
...

def isnull(self) -> DataFrame:
def is_null(self) -> DataFrame:
"""
Check for 'missing' or 'null' entries.

Expand All @@ -677,7 +677,7 @@ def isnull(self) -> DataFrame:

See also
--------
isnan
is_nan

Notes
-----
Expand All @@ -687,7 +687,7 @@ def isnull(self) -> DataFrame:
"""
...

def isnan(self) -> DataFrame:
def is_nan(self) -> DataFrame:
"""
Check for nan entries.

Expand All @@ -697,7 +697,7 @@ def isnan(self) -> DataFrame:

See also
--------
isnull
is_null

Notes
-----
Expand Down
2 changes: 1 addition & 1 deletion spec/API_specification/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ of objects and functions in the top-level namespace. The latter are:
:nosignatures:

__dataframe_api_version__
isnull
is_null
null

The ``DataFrame``, ``Column`` and ``GroupBy`` objects have the following
Expand Down