Skip to content

Remove 1.x tutorials #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
# Get tutorial notebooks for v2
# Get tutorial notebooks
VERSION=$(gh api /repos/deepset-ai/haystack/releases | \
jq -r '[.[].tag_name | select(test("^v2.[0-9]+.[0-9]+$"))] | first')
NOTEBOOKS=$(python ./scripts/generate_matrix.py --haystack-version "$VERSION" --include-main)
echo "matrix_v2={\"include\":$NOTEBOOKS}" >> "$GITHUB_OUTPUT"

run-tutorials-v2:
run-tutorials:
needs: generate-matrix
runs-on: ubuntu-latest
container: deepset/haystack:base-${{ matrix.haystack_version }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,36 +1,9 @@
name: Run Haystack 2.x Tutorials
name: Run Haystack Tutorials

on:
pull_request:
paths:
- "tutorials/*.ipynb"
# Exclude all v1.x tutorials, we can remove this when we drop support for it
- "!tutorials/01_Basic_QA_Pipeline.ipynb"
- "!tutorials/02_Finetune_a_model_on_your_data.ipynb"
- "!tutorials/03_Scalable_QA_System.ipynb"
- "!tutorials/04_FAQ_style_QA.ipynb"
- "!tutorials/05_Evaluation.ipynb"
- "!tutorials/06_Better_Retrieval_via_Embedding_Retrieval.ipynb"
- "!tutorials/07_RAG_Generator.ipynb"
- "!tutorials/08_Preprocessing.ipynb"
- "!tutorials/09_DPR_training.ipynb"
- "!tutorials/10_Knowledge_Graph.ipynb"
- "!tutorials/11_Pipelines.ipynb"
- "!tutorials/12_LFQA.ipynb"
- "!tutorials/13_Question_generation.ipynb"
- "!tutorials/14_Query_Classifier.ipynb"
- "!tutorials/15_TableQA.ipynb"
- "!tutorials/16_Document_Classifier_at_Index_Time.ipynb"
- "!tutorials/17_Audio.ipynb"
- "!tutorials/18_GPL.ipynb"
- "!tutorials/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.ipynb"
- "!tutorials/20_Using_Haystack_with_REST_API.ipynb"
- "!tutorials/21_Customizing_PromptNode.ipynb"
- "!tutorials/23_Answering_Multihop_Questions_with_Agents.ipynb"
- "!tutorials/22_Pipeline_with_PromptNode.ipynb"
- "!tutorials/24_Building_Chat_App.ipynb"
- "!tutorials/25_Customizing_Agent.ipynb"
- "!tutorials/26_Hybrid_Retrieval.ipynb"

jobs:
generate-matrix:
Expand All @@ -48,7 +21,7 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
# Get tutorial notebooks for v2
# Get tutorial notebooks
VERSION=$(gh api /repos/deepset-ai/haystack/releases | \
jq -r '[.[].tag_name | select(test("^v2.[0-9]+.[0-9]+$"))] | first')
NOTEBOOKS=$(python ./scripts/generate_matrix.py --haystack-version "$VERSION" --include-main)
Expand All @@ -60,34 +33,6 @@ jobs:
with:
matrix: true
files: tutorials/*.ipynb
# Ignore all 1.x tutorials, we can remove this as soon as we drop support for it
files_ignore: |
tutorials/01_Basic_QA_Pipeline.ipynb
tutorials/02_Finetune_a_model_on_your_data.ipynb
tutorials/03_Scalable_QA_System.ipynb
tutorials/04_FAQ_style_QA.ipynb
tutorials/05_Evaluation.ipynb
tutorials/06_Better_Retrieval_via_Embedding_Retrieval.ipynb
tutorials/07_RAG_Generator.ipynb
tutorials/08_Preprocessing.ipynb
tutorials/09_DPR_training.ipynb
tutorials/10_Knowledge_Graph.ipynb
tutorials/11_Pipelines.ipynb
tutorials/12_LFQA.ipynb
tutorials/13_Question_generation.ipynb
tutorials/14_Query_Classifier.ipynb
tutorials/15_TableQA.ipynb
tutorials/16_Document_Classifier_at_Index_Time.ipynb
tutorials/17_Audio.ipynb
tutorials/18_GPL.ipynb
tutorials/19_Text_to_Image_search_pipeline_with_MultiModal_Retriever.ipynb
tutorials/20_Using_Haystack_with_REST_API.ipynb
tutorials/21_Customizing_PromptNode.ipynb
tutorials/23_Answering_Multihop_Questions_with_Agents.ipynb
tutorials/22_Pipeline_with_PromptNode.ipynb
tutorials/24_Building_Chat_App.ipynb
tutorials/25_Customizing_Agent.ipynb
tutorials/26_Hybrid_Retrieval.ipynb

- name: Filter non changed notebooks
id: filter
Expand Down
Loading