Adjust CentOS deprecation notice to be more inclusive #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelines
reviewed
Jul 2, 2024
centos/deprecated.md
Outdated
| @@ -1 +1 @@ | |||
| This image is no longer supported/maintained (non-EOL tags last updated November 16, 2020, [docker-library/official-images#9102](https://github.com/docker-library/official-images/pull/9102); see also https://www.centos.org/centos-linux-eol/ and [docker-library/docs#2205](https://github.com/docker-library/docs/pull/2205)). Please adjust your usage accordingly. | |||
| *All* tags of this image are EOL ([June 30, 2024](https://www.redhat.com/en/topics/linux/centos-linux-eol) / [docker-library/official-images#17094](https://github.com/docker-library/official-images/pull/17094), but it was inactive/unmaintained long before that: meaningful tags were last updated November 16, 2020, [docker-library/official-images#9102](https://github.com/docker-library/official-images/pull/9102); see also https://www.centos.org/centos-linux-eol/ and [docker-library/docs#2205](https://github.com/docker-library/docs/pull/2205)). Please adjust your usage accordingly. | |||
There was a problem hiding this comment.
Suggested change
| *All* tags of this image are EOL ([June 30, 2024](https://www.redhat.com/en/topics/linux/centos-linux-eol) / [docker-library/official-images#17094](https://github.com/docker-library/official-images/pull/17094), but it was inactive/unmaintained long before that: meaningful tags were last updated November 16, 2020, [docker-library/official-images#9102](https://github.com/docker-library/official-images/pull/9102); see also https://www.centos.org/centos-linux-eol/ and [docker-library/docs#2205](https://github.com/docker-library/docs/pull/2205)). Please adjust your usage accordingly. | |
| *All* tags of this image are EOL ([June 30, 2024](https://www.redhat.com/en/topics/linux/centos-linux-eol) / [docker-library/official-images#17094](https://github.com/docker-library/official-images/pull/17094), although the last meaningful update was November 16, 2020, long before the EOL date [docker-library/official-images#9102](https://github.com/docker-library/official-images/pull/9102); see also https://www.centos.org/centos-linux-eol/ and [docker-library/docs#2205](https://github.com/docker-library/docs/pull/2205)). Please adjust your usage accordingly. |
There was a problem hiding this comment.
Applied with the minor addition of a colon after "long before the EOL date":
All tags of this image are EOL (June 30, 2024 / docker-library/official-images#17094, although the last meaningful update was November 16, 2020, long before the EOL date: docker-library/official-images#9102; see also https://www.centos.org/centos-linux-eol/ and docker-library/docs#2205). Please adjust your usage accordingly.
vs
All tags of this image are EOL (June 30, 2024 / docker-library/official-images#17094, although the last meaningful update was November 16, 2020, long before the EOL date docker-library/official-images#9102; see also https://www.centos.org/centos-linux-eol/ and docker-library/docs#2205). Please adjust your usage accordingly.
Co-authored-by: David Dooling <[email protected]>
yosifkit
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to docker-library/official-images#17094 to make the message more explicit about which versions are EOL/deprecated.