-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix silly npm warnings #10339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix silly npm warnings #10339
Conversation
The formal "compliance" stuff is automated in our build through the Component Governance tools. I think @Pilchie should be notified though, just as @Eilon was in the past despite the automatic stuff. In this case, the dependency is being updated in order to fix NPM warnings during installation (see linked issue) and is used only in test code. I approve ✔️ of this update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the ts-jest
update barfed on the lock file but c'est la vie.
Also looks like I forgot to run tests locally, and the update broke some stuff |
Yup, please let @Pilchie know about significant OSS updates. For me the most important ones were ones that affect the shipping product (even minor updates). For test/build-only assets I mostly cared about significant changes (e.g. new dependency). |
@@ -0,0 +1,12 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts-jest
changed something with how they compiled files which made the types now actually needed, so had to add a new config file to have the correct typeRoots
and use that for FunctionalTests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🆙 📅 |
Still approved. |
Fixes #10251
@anurse Who does dependency update things now? (This is test only)