Skip to content

Fix silly npm warnings #10339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2019
Merged

Fix silly npm warnings #10339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4483bb2
Fix silly npm warnings
BrennanConroy May 17, 2019
64e3b70
fixup
BrennanConroy May 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SignalR/clients/ts/FunctionalTests/func.jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ module.exports = {
],
globals: {
"ts-jest": {
"tsConfigFile": "../tsconfig.jest.json",
"skipBabel": true,
"tsConfig": "./tsconfig.jest.json",
"babelConfig": true,

// Needed in order to properly process the JS files
// We run 'tsc --noEmit' to get TS diagnostics before the test instead
"enableTsDiagnostics": false,
"diagnostics": false,
}
},
reporters: [
Expand Down
2 changes: 1 addition & 1 deletion src/SignalR/clients/ts/FunctionalTests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"karma-safari-launcher": "^1.0.0",
"karma-sauce-launcher": "^1.2.0",
"karma-sourcemap-loader": "^0.3.7",
"karma-summary-reporter": "^1.5.0",
"karma-summary-reporter": "^1.6.0",
"rxjs": "^6.3.3",
"ts-node": "^4.1.0",
"typescript": "^2.7.1",
Expand Down
12 changes: 12 additions & 0 deletions src/SignalR/clients/ts/FunctionalTests/tsconfig.jest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-jest changed something with how they compiled files which made the types now actually needed, so had to add a new config file to have the correct typeRoots and use that for FunctionalTests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"extends": "../tsconfig.base.json",
"compilerOptions": {
"module": "commonjs",
"noUnusedLocals": false,
"noUnusedParameters": false,
"typeRoots": [
"./node_modules/@types"
],
"allowJs": true
},
}
8 changes: 4 additions & 4 deletions src/SignalR/clients/ts/FunctionalTests/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,10 +1540,10 @@ karma-sourcemap-loader@^0.3.7:
dependencies:
graceful-fs "^4.1.2"

karma-summary-reporter@^1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/karma-summary-reporter/-/karma-summary-reporter-1.5.0.tgz#dc570299c7074774e388e10fa5f9e58f7a45ec14"
integrity sha1-3FcCmccHR3TjiOEPpfnlj3pF7BQ=
karma-summary-reporter@^1.6.0:
version "1.6.0"
resolved "https://registry.yarnpkg.com/karma-summary-reporter/-/karma-summary-reporter-1.6.0.tgz#f624da357b96014a1ea3f9bb0076c6800aa2204d"
integrity sha512-ptd4M8NAmtzwp+iN3pI3/s0EHH1lRekAyu+1/FkkyduVW4CUwfGg9B16FLN3+UYW10maWnP5yI+yXn2zahRyQg==
dependencies:
chalk "^1.1.3 || 2.x"

Expand Down
2 changes: 1 addition & 1 deletion src/SignalR/clients/ts/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"jest": "^24.1.0",
"jest-junit": "^5.1.0",
"rimraf": "^2.6.2",
"ts-jest": "^22.4.6",
"ts-jest": "^24.0.2",
"ts-loader": "^4.4.1",
"tslint": "^5.9.1",
"typescript": "^2.7.1",
Expand Down
Loading