Skip to content

Crankier server #12406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 15, 2019
Merged

Crankier server #12406

merged 12 commits into from
Aug 15, 2019

Conversation

staff0rd
Copy link
Contributor

Alternate solution for #9264, Crankier now includes the server itself, call it using the server command, and then point another instance of Crankier at it with the usual local command;

$ dotnet run -- server

Process ID: 4837
Hosting environment: Production
Content root path: /Users/staffordwilliams/git/aspnetcore/artifacts/bin/Crankier/Debug/netcoreapp3.0/
Now listening on: http://localhost:5000
Application started. Press Ctrl+C to shut down.
[00:00:00] Current: 412, peak: 412, connected: 236, disconnected: 0, rate: 236/s
[00:00:01] Current: 632, peak: 632, connected: 220, disconnected: 0, rate: 220/s
[00:00:02] Current: 851, peak: 851, connected: 219, disconnected: 0, rate: 219/s
[00:00:03] Current: 1087, peak: 1087, connected: 236, disconnected: 0, rate: 236/s
[00:00:04] Current: 1329, peak: 1329, connected: 242, disconnected: 0, rate: 242/s
[00:00:05] Current: 1568, peak: 1568, connected: 239, disconnected: 0, rate: 239/s
[00:00:06] Current: 1772, peak: 1772, connected: 204, disconnected: 0, rate: 204/s

Also, rather than spamming based on connection count, a hosted service now periodically echoes the output.

@Pilchie Pilchie added the area-signalr Includes: SignalR clients and servers label Jul 22, 2019
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add the copyright header to all the new files?

@staff0rd
Copy link
Contributor Author

done

@halter73
Copy link
Member

/azp run AspNetCore-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Approved pending nits.

@staff0rd
Copy link
Contributor Author

@halter73 i'll fix the threading stuff this evening. Regarding whitespace & brackets, why not lint for this in CI?

@staff0rd
Copy link
Contributor Author

requested changes are done

@staff0rd
Copy link
Contributor Author

updates made

@halter73 halter73 merged commit 6b4a101 into dotnet:master Aug 15, 2019
@halter73
Copy link
Member

Thanks @staff0rd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants