-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Crankier server #12406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crankier server #12406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you add the copyright header to all the new files?
src/SignalR/perf/benchmarkapps/Crankier/Server/ConnectionCounter.cs
Outdated
Show resolved
Hide resolved
done |
/azp run AspNetCore-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
src/SignalR/perf/benchmarkapps/Crankier/Server/ConnectionCounterHostedService.cs
Outdated
Show resolved
Hide resolved
src/SignalR/perf/benchmarkapps/Crankier/Server/ConnectionCounterHostedService.cs
Show resolved
Hide resolved
src/SignalR/perf/benchmarkapps/Crankier/Commands/ServerCommand.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Approved pending nits.
Co-Authored-By: Stephen Halter <[email protected]>
@halter73 i'll fix the threading stuff this evening. Regarding whitespace & brackets, why not lint for this in CI? |
requested changes are done |
updates made |
Thanks @staff0rd! |
Alternate solution for #9264, Crankier now includes the server itself, call it using the
server
command, and then point another instance of Crankier at it with the usuallocal
command;Also, rather than spamming based on connection count, a hosted service now periodically echoes the output.