-
Notifications
You must be signed in to change notification settings - Fork 10.4k
SignalR: Benchmark server logging #9264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: staff0rd <[email protected]>
Co-Authored-By: staff0rd <[email protected]>
Co-Authored-By: staff0rd <[email protected]>
Co-Authored-By: staff0rd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not touching the BenchmarkServer project if possible.
I'm fine with us creating a new example server project in the Crankier folder that is specific to Crankier usage.
Yeah, it's not super clear but the BenchmarkServer app is actually used other benchmarking logic we do elsewhere. Introducing some locks and logging may adversely affect that benchmark. Rather than an entirely separate app, a separate Hub with it's own endpoint URL would be OK with me. |
@BrennanConroy @anurse What if instead of creating yet another benchmark server app, we added an opt-in flag like Without the flag, we could register a |
I'm very in favor of any option that doesn't involve a whole new test app :). Command line arg sounds great. |
@BrennanConroy thoughts on options above? |
I'm still not a fan of making a precedent that we can modify the In your other PR you were saying you are not able to build this app because of the Directory.Build.Props file which we are planning on keeping, so I'm not sure how this will help. |
@anurse @halter73 What if I were to alter Crankier such that if you passed a For load testing purposes the scenario would then be
|
Sure, that sounds like a good approach. |
I'll open a new PR with a different approach. |
Gives a better idea of what the benchmark server is doing. Helpful for getting an overview when using multiple crankier clients to load test.
(connectionCount % 100 == 0)
to avoid console spamExample from a B2s instance;
I also have this if you wanna raise multiple crankier clients in containers. Remember to pull them down when you're finished as they'll live (bill) forever if you don't turn them off.