Skip to content

SignalR: Fix Crankier build #9976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2019

Conversation

staff0rd
Copy link
Contributor

@staff0rd staff0rd commented May 5, 2019

Fixes Crankier & BenchMarkServer builds.

A couple of questions;

  1. Why were the projects dropped from SignalR.sln? (Fix SignalR build from VS #8492)
  2. In Use NuGet.Config for SignalR benchmarks #9958 I see a note from @sebastienros that says we don't want to inherit Directory.Build.props, but both .csproj are using Reference.

@Eilon Eilon added the area-signalr Includes: SignalR clients and servers label May 6, 2019
@analogrelay analogrelay added this to the 3.0.0-preview6 milestone May 20, 2019
@staff0rd staff0rd changed the title SignalR: Fix benchmarkapps build SignalR: Fix Crankier build May 23, 2019
@staff0rd
Copy link
Contributor Author

@BrennanConroy can you please review this again? I've closed #9264 and will instead move that functionality to Crankier as suggested. This PR now represents moving the Directory* stuff so it only affects the benchmark server and the IHostingEnvironment deprecation update.

@BrennanConroy BrennanConroy merged commit c2e2d7d into dotnet:master May 23, 2019
@BrennanConroy
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants