Fix AzureAd options validation #13480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
added
area-auth
|
Should we just consider reverting the validation change instead? |
|
The validation change was supposedly just to make things easier to debug, if its causing regressions, that seems not worth the supposed benefit |
|
The validation is useful, it just got applied too broadly. |
HaoK
approved these changes
Aug 27, 2019
javiercn
approved these changes
Aug 27, 2019
|
This was approved by tactics, once test failure is understood. |
|
Flaky blazor test, retrying. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask mode template
Description
#9967 added options validation for AzureAd auth options, but it introduced a regression where it would throw for other cookie or jwt auth providers.
#13327 was a community members fix for cookies in master. I've cherry picked that commit, also fixed jwt, and added tests.
Customer Impact
Customers may not be able to use AzureAd auth combine with other kinds of auth in one app.
Regression?
Yes, identified externally in preview8.
Risk
Low.
@Pilchie