Skip to content

Ensure AzureADOptions.Instance is set #9967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

Ensure AzureADOptions.Instance is set #9967

merged 1 commit into from
May 16, 2019

Conversation

mderriey
Copy link
Contributor

@mderriey mderriey commented May 4, 2019 •
edited
Loading

Validates that AzureADOptions.Instance is set for easier troubleshooting

Addresses #6022

@mderriey
Copy link
Contributor Author

mderriey commented May 4, 2019

I tried to create a resource file to store the error message but couldn't get the associated C# file to look like an existing one, like the one in src\Security\Authentication\Core.

@mderriey mderriey force-pushed the 6022-ensure-azureadoptions-instance-is-set branch from 093e5ce to fa6b929 Compare May 5, 2019 01:12
@mderriey
Copy link
Contributor Author

mderriey commented May 5, 2019 •
edited
Loading

Hi there 👋

While the build failure seems unrelated to my changes, please let me know if you think they're linked.

Related to my initial message about Resources.Designer.cs files, can you let me know how they're generated? When I added a resource file through VS, it definitely didn't look like the existing ones in this repo:

  • much larger comment about the fact they're autogenerated;
  • FormatXXX methods were not generated either.

@Eilon Eilon added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label May 6, 2019
@Eilon Eilon requested review from HaoK and Tratcher May 6, 2019 04:07
@mderriey mderriey force-pushed the 6022-ensure-azureadoptions-instance-is-set branch from fa6b929 to 25e4efa Compare May 6, 2019 23:13
@mderriey mderriey force-pushed the 6022-ensure-azureadoptions-instance-is-set branch from 25e4efa to 072e458 Compare May 9, 2019 10:16
@mderriey
Copy link
Contributor Author

👋 @Tratcher @HaoK

Could you please let me know if there's something you want me to change in this PR?

Appreciate your time 🙏

@Tratcher
Copy link
Member

@HaoK can you take this? You know the options validation.

@HaoK
Copy link
Member

HaoK commented May 16, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=184160

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2489
https://github.com/aspnet/AspNetCore-Internal/issues/2200

@Tratcher Tratcher merged commit 3da1b10 into dotnet:master May 16, 2019
@Tratcher Tratcher added this to the 3.0.0-preview6 milestone May 16, 2019
@Tratcher
Copy link
Member

Thanks

@mderriey mderriey deleted the 6022-ensure-azureadoptions-instance-is-set branch May 16, 2019 22:28
@vbornand vbornand mentioned this pull request Aug 21, 2019
Closed
@Tratcher Tratcher mentioned this pull request Aug 27, 2019
Merged
@JunTaoLuo JunTaoLuo mentioned this pull request Jun 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Milestone
3.0.0-preview6
Development

Successfully merging this pull request may close these issues.
5 participants
@mderriey @Tratcher @HaoK @aspnet-hello @Eilon