-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix resend email confirmation #14118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -42,7 +42,7 @@ | |||
<a asp-page="./Register" asp-route-returnUrl="@Model.ReturnUrl">Register as a new user</a> | |||
</p> | |||
<p> | |||
<button id="resend-confirmation" type="submit" asp-page-handler="SendVerificationEmail" class="btn-link" style="padding:0px;margin:0px;border:0px">Resend email confirmation</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Do we still have inline styles anywhere? We should avoid those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few class="btn btn-default"
on buttons, safe to just remove them everywhere?
src/Identity/testassets/Identity.DefaultUI.WebSite/StartupBase.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although to be fair is really hard to validate this just by looking at the code. I saw you added a test, so I'm trusting the tests 😄.
src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ResendEmailConfirmation.cshtml
Outdated
Show resolved
Hide resolved
Update src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ResendEmailConfirmation.cshtml Co-Authored-By: campersau <[email protected]> Resend not reset Update ref Add new email confirmation link to templates test Fix test Revert website change
Update src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ResendEmailConfirmation.cshtml Co-Authored-By: campersau <[email protected]> Resend not reset Update ref Add new email confirmation link to templates test Fix test Revert website change
… into identity-confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two concerns, I'm only really worried about the user == null one, but as long as there's a good reason for that behavior I won't block on it.
src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ResendEmailConfirmation.cshtml.cs
Show resolved
Hide resolved
/// </summary> | ||
[AllowAnonymous] | ||
[IdentityDefaultUI(typeof(ResendEmailConfirmationModel<>))] | ||
public abstract class ResendEmailConfirmationModel : PageModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could unify this considering that it seems to just be a copy of the V3 one, but if there's not an existing structure for making those two versions share code I can see it being not worth the effort.
Fix for #13462