Skip to content

Remove partial resend email functionality #14901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2019
Merged

Remove partial resend email functionality #14901

merged 2 commits into from
Oct 21, 2019

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Oct 10, 2019 •
edited
Loading

Fixes #14659

Note: corresponding code needs to be removed from scaffolding as well for 3.1

@HaoK HaoK added 3.1-candidate area-identity Includes: Identity and providers labels Oct 10, 2019
@HaoK HaoK added this to the 3.1.0-preview2 milestone Oct 10, 2019
@HaoK HaoK mentioned this pull request Oct 10, 2019
Merged
@HaoK HaoK marked this pull request as ready for review October 17, 2019 20:21
@HaoK HaoK requested review from ajcvickers and blowdart October 17, 2019 20:22
@HaoK
Copy link
Member Author

HaoK commented Oct 17, 2019

Per discussion with @blowdart we are removing some of the partial functionality, and adding this back completely (and reworked) in 5.0 via: #14118

blowdart
blowdart approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad but necessary

@HaoK HaoK merged commit 4fd9d38 into release/3.1 Oct 21, 2019
@HaoK HaoK deleted the identity-cleanup branch October 21, 2019 16:49
@HaoK HaoK mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowdart blowdart blowdart approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
3.1.0-preview2
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoK @blowdart