Fix flaky LongPolling tests #14395
Merged
Fix flaky LongPolling tests #14395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Oct 31, 2019
src/SignalR/common/testassets/Tests.Utils/VerifyNoErrorsScope.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Oct 31, 2019
src/SignalR/common/testassets/Tests.Utils/VerifyNoErrorsScope.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Oct 31, 2019
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@BrennanConroy to confirm that this is ready-to-merge from your perspective (I know I need to do the merge) |
analogrelay
added
the
tell-mode
|
Yes, it's ready to merge |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only change.
Some of the test failure reports: #6597 and https://github.com/aspnet/AspNetCore-Internal/issues/2686
We decided to avoid making the product changes in 2.1 and 2.2 as there has never been a customer report of this issue and we don't want to cause unnecessary churn.
The fix in 3.0 was #8225