Better handle HttpConnectionContext state transitions #8225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
commented
Mar 6, 2019
| // Capture the connection state | ||
| status = connection.Status; | ||
|
|
||
| lastSeenUtc = connection.LastSeenUtc; |
There was a problem hiding this comment.
This fixes a potential race. Since there were no memory barriers before, it was theoretically possible to observe an Inactive status with a LastSeenUtc set long before the connection last became inactive. There's also the possibility of tearing without a lock.
halter73
commented
Mar 6, 2019
| @@ -100,8 +100,11 @@ public partial class HttpConnectionContext : Microsoft.AspNetCore.Connections.Co | |||
| public System.Threading.SemaphoreSlim WriteLock { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } } | |||
| [System.Diagnostics.DebuggerStepThroughAttribute] | |||
| public System.Threading.Tasks.Task DisposeAsync(bool closeGracefully = false) { throw null; } | |||
| public void MarkInactive() { } | |||
There was a problem hiding this comment.
@davidfowl What's the deal with reference assemblies for pubternal classes? Do we really have to keep back compat? If so, should we just make everything new internal?
halter73
added
area-signalr
|
@BrennanConroy Ping. |
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
Outdated
Show resolved
Hide resolved
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
Outdated
Show resolved
Hide resolved
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionContext.cs
Outdated
Show resolved
Hide resolved
halter73
force-pushed
the
halter73/brecon/longpollrace
branch
3 times, most recently
from
102aa7b to
1810e77
Compare
halter73
force-pushed
the
halter73/brecon/longpollrace
branch
from
da3caae to
03e65d5
Compare
|
@BrennanConroy I added the test. |
BrennanConroy
approved these changes
Mar 14, 2019
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
Outdated
Show resolved
Hide resolved
src/SignalR/common/Http.Connections/test/HttpConnectionDispatcherTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible alternative to #8114