Skip to content

Tests for GetHttpProtocolVersion #14477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

gfoidl
Copy link
Member

@gfoidl gfoidl commented Sep 26, 2019

Addresses #14139

/cc: @JamesNK

@JamesNK
Copy link
Member

JamesNK commented Sep 30, 2019

Opps, I missed seeing this.

There is nothing wrong with unit testing this. However, the tests I'd be most interested in for verifying Request.Protocol in Kestrel vs IIS is end-to-end functional/integration tests.

@gfoidl
Copy link
Member Author

gfoidl commented Sep 30, 2019

for verifying Request.Protocol in Kestrel vs IIS is end-to-end functional/integration tests.

This it out of my scope (i.e. I don't know how and where to put these tests), that's why this PR didn't add such tests (as I'd also like to see these).
If you can give me some pointers I can add tests for this.

@JamesNK
Copy link
Member

JamesNK commented Sep 30, 2019

No problem. They're more complex. Probably better than an ASP.NET engineer handles it.

@jkotalik
Copy link
Contributor

@JamesNK I can take a look into this. I thought it would be easy to add a test, but there needs to be some casing on whether Http2 is supported/enabled or not, which is tricky.

@jkotalik
Copy link
Contributor

I still think we can merge this PR as is though!

@gfoidl
Copy link
Member Author

gfoidl commented Sep 30, 2019

@jkotalik thx. When you have your PR ready, can you please tag me, as I'm interested to see how it's done?

@gfoidl
Copy link
Member Author

gfoidl commented Oct 4, 2019

#14644 is the PR for e2e-tests (just to put the reference here).

@jkotalik
Copy link
Contributor

jkotalik commented Oct 7, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jkotalik
Copy link
Contributor

jkotalik commented Oct 7, 2019

@HaoK do you know what's up with teh ARM64 queues failing here?

@HaoK
Copy link
Member

HaoK commented Oct 7, 2019

The queues ran out of disk space, but it should be fixed now if you retry

@jkotalik
Copy link
Contributor

jkotalik commented Oct 7, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jkotalik jkotalik merged commit 53a54d9 into dotnet:master Oct 8, 2019
@jkotalik
Copy link
Contributor

jkotalik commented Oct 8, 2019

@gfoidl Thanks!

@gfoidl gfoidl deleted the http2_version_tests branch October 8, 2019 17:55
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants