-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Tests for GetHttpProtocolVersion #14477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Opps, I missed seeing this. There is nothing wrong with unit testing this. However, the tests I'd be most interested in for verifying |
This it out of my scope (i.e. I don't know how and where to put these tests), that's why this PR didn't add such tests (as I'd also like to see these). |
No problem. They're more complex. Probably better than an ASP.NET engineer handles it. |
@JamesNK I can take a look into this. I thought it would be easy to add a test, but there needs to be some casing on whether Http2 is supported/enabled or not, which is tricky. |
I still think we can merge this PR as is though! |
@jkotalik thx. When you have your PR ready, can you please tag me, as I'm interested to see how it's done? |
#14644 is the PR for e2e-tests (just to put the reference here). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@HaoK do you know what's up with teh ARM64 queues failing here? |
The queues ran out of disk space, but it should be fixed now if you retry |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@gfoidl Thanks! |
Addresses #14139
/cc: @JamesNK