Http2 test for IIS #14644
Http2 test for IIS #14644
Conversation
| @@ -37,7 +37,7 @@ public static void AddHttpsToServerConfig(this IISDeploymentParameters parameter | |||
|
|
|||
| element.Descendants("access") | |||
| .Single() | |||
| .SetAttributeValue("sslFlags", "Ssl, SslNegotiateCert"); | |||
| .SetAttributeValue("sslFlags", "None"); | |||
There was a problem hiding this comment.
I need to read into setting this to None. Setting this to none makes it seem like SSL is disabled for the entire site. I'm still seeing in the application that it is binding to https and using HTTP/2. Maybe it's using h2c?
There was a problem hiding this comment.
Nvrm, I think it's a poor doc. I'm seeing https on the server.
There was a problem hiding this comment.
So what does setting this to None actually do?
There was a problem hiding this comment.
It removes client cert validation I believe.
| @@ -63,6 +63,11 @@ private async Task ServerAddresses(HttpContext ctx) | |||
| await ctx.Response.WriteAsync(string.Join(",", serverAddresses.Addresses)); | |||
| } | |||
|
|
|||
| private async Task CheckIsHttp2(HttpContext ctx) | |||
There was a problem hiding this comment.
| private async Task CheckIsHttp2(HttpContext ctx) | |
| private async Task CheckProtocol(HttpContext ctx) |
jkotalik
force-pushed
the
jkotalik/addHttp2Test
branch
from
faff31b to
8e83b3e
Compare
| var client = CreateNonValidatingClient(deploymentResult); | ||
| client.DefaultRequestVersion = HttpVersion.Version20; | ||
|
|
||
| Assert.Equal("HTTP/2", await client.GetStringAsync($"/CheckIsHttp2")); |
There was a problem hiding this comment.
Let's test other protocol versions too?
There was a problem hiding this comment.
Other tests already verify this behavior (checking http 1.1)
jkotalik
force-pushed
the
jkotalik/addHttp2Test
branch
from
8e83b3e to
c50d70f
Compare
amcasey
added
area-networking
Fixes #14139.
cc @gfoidl