HttpSys GoAway #14522
Merged
HttpSys GoAway #14522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
force-pushed
the
tratcher/3.1/goaway
branch
2 times, most recently
from
1d687d9 to
fdbc8ab
Compare
Tratcher
commented
Sep 30, 2019
jkotalik
reviewed
Sep 30, 2019
Tratcher
force-pushed
the
tratcher/3.1/goaway
branch
from
0b67907 to
eefa8c2
Compare
jkotalik
approved these changes
Oct 1, 2019
halter73
approved these changes
Oct 1, 2019
|
@anurse this is ready to merge. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13356 We have a customer that needs to trigger an HTTP/2 GoAway via Http.Sys so that their load balancer can redirect traffic. Http.Sys added a response flag we can set for this, but only on 1909.
My test app did have to add a manifest for the OS version check to work:
https://stackoverflow.com/questions/33328739/system-environment-osversion-returns-wrong-version (not sure how it worked on my other machine without this.)
I verified this manually using wireshark. Post preview1 we have a work item to add helix queues that support new windows builds (https://github.com/aspnet/AspNetCore-Internal/issues/3170). Stephen also has a branch with tools that will allow us to write unit tests at the protocol/frame level (#14582).