Add SocketConnectionFactory and http2cat #14582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
force-pushed
the
halter73/http2cat
branch
from
eb80176 to
434f340
Compare
Merged
jkotalik
reviewed
Oct 1, 2019
| public static readonly int MaxRequestHeaderFieldSize = 16 * 1024; | ||
| public static readonly string _4kHeaderValue = new string('a', 4096); | ||
|
|
||
| public static readonly IEnumerable<KeyValuePair<string, string>> _browserRequestHeaders = new[] |
There was a problem hiding this comment.
Anyway to share with this with our test infrastructure.
There was a problem hiding this comment.
Maybe. It's already diverged a fair bit from Http2TestBase, so I'm not sure it's worth the effort though.
halter73
force-pushed
the
halter73/http2cat
branch
from
09ce70f to
db7f16c
Compare
jkotalik
reviewed
Oct 4, 2019
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp5.0</TargetFramework> |
There was a problem hiding this comment.
This should be $(DefaultNetCoreTargetFramework)
jkotalik
approved these changes
Oct 4, 2019
|
This certainly meets its manual testing objectives. Here are some ideas for making it more broadly applicable in the future. E.g. I'd like to directly consume this as a library in Kestrel and HttpSys tests and remove the duplicate infrastructure.
None of this is a near term priority. |
|
@Tratcher can you capture that in an issue so we don’t lose it |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add SslStream
TODO: Support half-closing the SocketConnection