Skip to content

Remove null check for logger in HttpsConnectionMiddleware #16736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2019
Merged

Remove null check for logger in HttpsConnectionMiddleware #16736

merged 1 commit into from
Nov 1, 2019

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Nov 1, 2019

Fixes #16735

@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Nov 1, 2019
@halter73
Copy link
Member

halter73 commented Nov 1, 2019

We're going to have to be careful that #16720 doesn't re-add a null check when it gets merged to master.

@halter73 halter73 merged commit ab5b5a4 into dotnet:master Nov 1, 2019
@halter73
Copy link
Member

halter73 commented Nov 1, 2019

Thanks @Kahbazi!

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.

Remove null check for logger in HttpsConnectionMiddleware
5 participants
@Kahbazi @halter73 @analogrelay @Tratcher @amcasey