Use new EventId for bad dev cert log #16720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
halter73
added
the
feature-platform
|
Hmm, needs a centralized list of log ids? (to consider in master) |
|
Go ahead and merge. Thanks for catching. |
halter73
force-pushed
the
halter73/new-event-id
branch
from
cdeff4c to
402b737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #16659.
We are already using EventId 2 in HttpsConnectionMiddleware for handshake timeouts, so I made the bad dev cert log use a new EventId.
https://github.com/aspnet/AspNetCore/blob/e89f2f450263f865f20c2c7b77f4e30daedc7c47/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs#L206-L211
We could also continue to use EventId 1 instead since that was what we were using previously for generic AuthenticationExceptions.
@Pilchie Do I need to do anything special to get this approved for 3.1.0-preview3, or can I piggyback on the #16659 approval since it's just a fixup?