[Platform] Provide a better error message when the developer certificate can't be used #16659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
mkArtakMSFT
added
the
feature-platform
javiercn
commented
Oct 30, 2019
javiercn
force-pushed
the
javiercn/kestrel-https-invalid-cert-improvement
branch
2 times, most recently
from
cbf6f7c to
8e9cc2d
Compare
javiercn
force-pushed
the
javiercn/kestrel-https-invalid-cert-improvement
branch
from
8e9cc2d to
43d59cf
Compare
analogrelay
reviewed
Oct 30, 2019
src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs
Outdated
Show resolved
Hide resolved
|
@Pilchie FYI |
Tratcher
reviewed
Oct 30, 2019
src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs
Outdated
Show resolved
Hide resolved
javiercn
commented
Oct 30, 2019
|
🆙 📅 |
analogrelay
reviewed
Oct 30, 2019
Co-Authored-By: Andrew Stanton-Nurse <[email protected]>
Tratcher
approved these changes
Oct 30, 2019
|
@Pilchie this is just waiting for your approval. |
Pilchie
approved these changes
Oct 31, 2019
| @@ -150,7 +150,7 @@ private static int CheckHttpsCertificate(CommandOption trust, IReporter reporter | |||
| { | |||
| var now = DateTimeOffset.Now; | |||
| var certificateManager = new CertificateManager(); | |||
|
Approved for 3.1.0-Preview3. Thanks @javiercn |
javiercn
added a commit
that referenced
this pull request
Dec 4, 2019
…ate can't be used (#16659) Improves the error message Kestrel gives when the developer certificate key is not available for some reason.
mkArtakMSFT
pushed a commit
that referenced
this pull request
Jan 16, 2020
…keys on Mac OS (3.0) (#17580) * [Platform] Provide a better error message when the developer certificate can't be used (#16659) Improves the error message Kestrel gives when the developer certificate key is not available for some reason. * [Platform] Add logic to dotnet-dev-certs to detect and fix certificates with inaccessible keys on Mac OS * Update the docs link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #15118
Long story short, Mac OS will introduce notarization for apps, which changes the identity of
dotnet.exewith regards to the OS.That makes the keys for certs in the cert store (backed by keychain) not accessible to the app if the certificate was created with a
dotnet.exethat was not notarized.Users upgrading to 3.1 in the future will encounter this on Mac OS and they won't get any feedback about what's going on other than a failed connection screen in the browser).
To help users in this scenario we are introducing an additional error message with instructions on what to do when we detect the developer certificate is being used for HTTPS, so that at least there is a proper error message.
We are still investigating all the ramifications of this issue, hence the "partially addresses it"