[Platform] Detect and fix certificates with potentially inaccessible keys on Mac OS (3.0) #17580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate can't be used (#16659) Improves the error message Kestrel gives when the developer certificate key is not available for some reason.
javiercn
added
the
feature-platform
…es with inaccessible keys on Mac OS
javiercn
force-pushed
the
javiercn/https-mac-os-30
branch
from
a97f7f6 to
9c989c5
Compare
javiercn
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
|
@aspnet/build There seems to be an issue here with the builds on the CI not even starting |
pranavkm
approved these changes
Dec 5, 2019
halter73
approved these changes
Dec 5, 2019
jamshedd
added
Servicing-approved
|
/AzurePipelines run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
All required tests passing. @javiercn @mkArtakMSFT are we waiting for anything here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are signing the SDK installer and packages for Mac OS Catalina compliance with the requirement to have packages notarized. That change affects the way HTTPS works in ASP.NET Core and prevents users from running their ASP.NET Core applications.
To mitigate the issue we are including logic in Kestrel that detects this situation and informs customers of what steps to take to mitigate the issue and we are updating the "dotnet dev-certs" tool to detect when this situation can happen and to fix it automatically when the "dotnet dev-certs https" command is run.
Customer Impact
High
Once a customer installs an updated SDK version they won't be able to run their applications normally unless they fix the existing certificate.
Regression?
No, this is a new requirement introduced by Mac OS Catalina.
Risk
Low, the runtime changes are already present in 3.1 and the changes on the tool are simple.
Implementation details