-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Move API Review Process doc to 'docs' #18367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes it easier to submit PRs and propose process changes. It also helps consolidate our documentation in the `docs/` folder. I also updated the area list to include all of my team's areas.
* area-security | ||
* area-servers | ||
* area-signalr | ||
* area-websockets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's support for it, I'd also be OK with flipping this to be a "Areas that don't need incremental API review" list. What would that look like?
- Blazor?
- Other MVC areas?
At the moment, there isn't really an area in my team that I wouldn't put through incremental API review. Most are pretty mature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flipping this loosens up the rule as somebody can interpret it as "These are not required and nobody claims that what I am working on is required too. Let's just have a white-list
approach".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I'm OK with that.
Hello @anurse! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This makes it easier to submit PRs and propose process changes. It also helps consolidate our documentation in the
docs/
folder.I also updated the area list to include all of my team's areas.
TODO after merge:
api-ready-for-review
is labelled indicating the next steps and the expectations (and a link to this doc, which is why I'm waiting until it's merged).cc @jkotalik