Skip to content

Move API Review Process doc to 'docs' #18367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Feb 21, 2020
Merged

Move API Review Process doc to 'docs' #18367

1 commit merged into from
Feb 21, 2020

Conversation

analogrelay
Copy link
Contributor

@analogrelay analogrelay commented Jan 15, 2020

This makes it easier to submit PRs and propose process changes. It also helps consolidate our documentation in the docs/ folder.

I also updated the area list to include all of my team's areas.

TODO after merge:

  • Replace Uncyclo Page with link to this doc
  • Add msftbot rule to comment when api-ready-for-review is labelled indicating the next steps and the expectations (and a link to this doc, which is why I'm waiting until it's merged).

cc @jkotalik

This makes it easier to submit PRs and propose process changes. It also helps consolidate our documentation in the `docs/` folder.

I also updated the area list to include all of my team's areas.
* area-security
* area-servers
* area-signalr
* area-websockets
Copy link
Contributor Author

@analogrelay analogrelay Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's support for it, I'd also be OK with flipping this to be a "Areas that don't need incremental API review" list. What would that look like?

  • Blazor?
  • Other MVC areas?

At the moment, there isn't really an area in my team that I wouldn't put through incremental API review. Most are pretty mature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flipping this loosens up the rule as somebody can interpret it as "These are not required and nobody claims that what I am working on is required too. Let's just have a white-list approach".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I'm OK with that.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2020
@ghost
Copy link

ghost commented Feb 21, 2020

Hello @anurse!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@analogrelay
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ghost ghost merged commit bd02add into master Feb 21, 2020
@ghost ghost deleted the anurse/move-api-review-doc branch February 21, 2020 19:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants