Added Write/WriteLine ReadOnlySpan<char> override to HttpResponseStreamWriter #18445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefranz
requested review from
analogrelay,
jkotalik and
Tratcher
as code owners
ghost
added
the
benaadams
approved these changes
Jan 18, 2020
|
Tests failures should be unrelated |
|
I don't think this is the right issue number. |
jkotalik
reviewed
Jan 21, 2020
| @@ -161,10 +161,12 @@ public partial class HttpResponseStreamWriter : System.IO.TextWriter | |||
| public override System.Threading.Tasks.Task FlushAsync() { throw null; } | |||
| public override void Write(char value) { } | |||
| public override void Write(char[] values, int index, int count) { } | |||
| public override void Write(System.ReadOnlySpan<char> values) { } | |||
| public override void Write(string value) { } | |||
| public override System.Threading.Tasks.Task WriteAsync(char value) { throw null; } | |||
| public override System.Threading.Tasks.Task WriteAsync(char[] values, int index, int count) { throw null; } | |||
There was a problem hiding this comment.
Should we add a parallel method for WriteAsync that accepts a ReadOnlyMemory?
There was a problem hiding this comment.
I have #18451 for those, but it is based on this one, so I will mark it ready for review once this is merged. Unless you prefer to combine it.
jkotalik
reviewed
Jan 21, 2020
| } | ||
|
|
||
| int written = 0; | ||
| while (written < values.Length) |
There was a problem hiding this comment.
nit: save values.Length in a local rather than checking every iteration of the loop. nvrm you are slicing it
jkotalik
added
the
api-suggestion
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #2895
/cc @benaadams