Skip to content

Added Write/WriteLine ReadOnlySpan/ReadOnlyMemory overrides to HttpResponseStreamWriter #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 9, 2020
Merged

Added Write/WriteLine ReadOnlySpan/ReadOnlyMemory overrides to HttpResponseStreamWriter #18451

merged 11 commits into from
Feb 9, 2020

Conversation

alefranz
Copy link
Contributor

@alefranz alefranz commented Jan 19, 2020 •
edited by analogrelay
Loading

Fixes #2895

Based on #18445. Will rebase and mark ready for review once that one is merged.

@ghost ghost added the area-servers label Jan 19, 2020
@alefranz alefranz mentioned this pull request Jan 21, 2020
Closed
@jkotalik jkotalik added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Jan 22, 2020
@jkotalik
Copy link
Contributor

Also linking #16740 as it's the main reason to fix this behavior. TL;DR is that by not overriding async methods TextWriter methods, we hit an exception with synchronous operations being disallowed.

jkotalik
jkotalik reviewed Jan 22, 2020
View reviewed changes
jkotalik
jkotalik reviewed Jan 22, 2020
View reviewed changes
@jkotalik
Copy link
Contributor

Also linking #16740 as it's the main reason to fix this behavior. TL;DR is that by not overriding async methods TextWriter methods, we hit an exception with synchronous operations being disallowed.

@alefranz alefranz marked this pull request as ready for review January 23, 2020 00:17
@alefranz alefranz changed the title Added Write/WriteLine ReadOnlyMemory<char> overrides to HttpResponseStreamWriter Added Write/WriteLine ReadOnlySpan/ReadOnlyMemory overrides to HttpResponseStreamWriter Feb 3, 2020
@alefranz alefranz mentioned this pull request Feb 5, 2020
Merged
@jkotalik jkotalik self-assigned this Feb 7, 2020
@jkotalik jkotalik removed the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Feb 7, 2020
@jkotalik
Copy link
Contributor

jkotalik commented Feb 7, 2020

Because these are overrides, we don't need to do an API approval process.

@jkotalik jkotalik merged commit 6e0a4fc into dotnet:master Feb 9, 2020
@jkotalik
Copy link
Contributor

jkotalik commented Feb 9, 2020

Great job as always @alefranz . Thanks!

@alefranz
Copy link
Contributor Author

alefranz commented Feb 9, 2020

Thank you, @jkotalik ! 😳

@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Feb 11, 2020
@alefranz alefranz mentioned this pull request Feb 11, 2020
Closed
@melnikov77 melnikov77 mentioned this pull request Feb 12, 2020
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotalik jkotalik jkotalik approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@jkotalik jkotalik

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.

Override Span and Memory Writes for HttpResponseStreamWriter
4 participants
@alefranz @jkotalik @analogrelay @amcasey