[master] Update dependencies from dotnet/efcore

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

• Subscription: ccafa991-4408-48df-d45d-08d76e1d3434
• Build: 20200220.6
• Date Produced: 2/21/2020 12:34 AM
• Commit: 8f730925a179d31311e1f4dc22bb8d5015488401
• Branch: refs/heads/master
• Updates:
  • Microsoft.EntityFrameworkCore.Tools -> 5.0.0-preview.2.20120.6
  • Microsoft.EntityFrameworkCore.SqlServer -> 5.0.0-preview.2.20120.6
  • dotnet-ef -> 5.0.0-preview.2.20120.6
  • Microsoft.EntityFrameworkCore -> 5.0.0-preview.2.20120.6
  • Microsoft.EntityFrameworkCore.InMemory -> 5.0.0-preview.2.20120.6
  • Microsoft.EntityFrameworkCore.Relational -> 5.0.0-preview.2.20120.6
  • Microsoft.EntityFrameworkCore.Sqlite -> 5.0.0-preview.2.20120.6

[ghost]

Auto-approving dependency update.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[dougbu]

Running non-quarantined tests.
Microsoft (R) Test Execution Command Line Tool Version 16.3.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:02.21]     Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.Customize_migrations_end_point [FAIL]
[xUnit.net 00:00:02.26]     Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.Error_page_displayed_pending_migrations [FAIL]
[xUnit.net 00:00:02.49]     Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.Error_page_then_apply_migrations [FAIL]
  X Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.DatabaseErrorPageMiddlewareTest.Customize_migrations_end_point [17ms]
  Error Message:
   Microsoft.EntityFrameworkCore.DbUpdateException : An error occurred while updating the entries. See the inner exception for details.
---- Microsoft.Data.Sqlite.SqliteException : SQLite Error 1: 'no such table: Blogs'.
  Stack Trace:
     at Microsoft.EntityFrameworkCore.Update.ReaderModificationCommandBatch.Execute(IRelationalConnection connection)
   at Microsoft.EntityFrameworkCore.Update.Internal.BatchExecutor.Execute(IEnumerable`1 commandBatches, IRelationalConnection connection)
   at Microsoft.EntityFrameworkCore.Storage.RelationalDatabase.SaveChanges(IList`1 entries)
   at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.SaveChanges(IList`1 entriesToSave)

@ajcvickers has there been an EF Core change that may have changed how or when SQLite tables are created?

System.InvalidOperationException: Unable to resolve service for type 'Microsoft.EntityFrameworkCore.Metadata.Conventions.Infrastructure.ProviderConventionSetBuilderDependencies' while attempting to activate 'Microsoft.EntityFrameworkCore.Migrations.Internal.SnapshotModelProcessor'.
 at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateArgumentCallSites(Type serviceType, Type implementationType, CallSiteChain callSiteChain, ParameterInfo[] parameters, Boolean throwIfCallSiteNotFound)
 at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateConstructorCallSite(ResultCache lifetime, Type serviceType, Type implementationType, CallSiteChain callSiteChain)\r\n at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(ServiceDescriptor descriptor, Type serviceType, CallSiteChain callSiteChain, Int32 slot)
 at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(Type serviceType, CallSiteChain callSiteChain)
...
Expected: True
Actual: False

This also has the appearance of a breaking change in the incoming EF packages.

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[dougbu]

ping @ajcvickers

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[ajcvickers]

@dougbu I don't believe there was any intentional break here.

@bricelam @AndriySvyryd Does this look like something that we could have broken recently?

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[dougbu]

FYI the update looks like it spans 39 commits in dotnet/efcore ☹️ dotnet/efcore@e3f6eee...1a5c4fb

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[smitpatel]

System.InvalidOperationException: Unable to resolve service for type 'Microsoft.EntityFrameworkCore.Metadata.Conventions.Infrastructure.ProviderConventionSetBuilderDependencies' while attempting to activate 'Microsoft.EntityFrameworkCore.Migrations.Internal.SnapshotModelProcessor'.

In dotnet/efcore#19896 SnapshotModelProcessor took new dependency on ProviderConventionSetBuilderDependencies. Seems like something is wrong there.

cc: @AndriySvyryd

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[AndriySvyryd]

The new dependency is intentional, perhaps the projects/templates need to be updated to pick up the new version

[dotnet-maestro]

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Tests: Helix x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[ajcvickers]

@dougbu It's looking like ASP.NET might be pulling in inconsistent packages for EF Core. How can we figure out what versions are being pulled in?

[dotnet-maestro]

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

• ✔️ Standard Merge Policies Succeeded - Successful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: macOS 10.13), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Code check), aspnetcore-ci (Build Build: macOS)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

[dougbu]

@ajcvickers I'm not positive about the "inconsistent versions" you mentioned. Suspect the bot pulled in new versions and straightened everything out 😺

[AndriySvyryd]

@dougbu I pushed a commit that reverted the change, but the underlying issue is still present.